Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypedDict tests don't typecheck #2755

Closed
ddfisher opened this issue Jan 25, 2017 · 5 comments
Closed

TypedDict tests don't typecheck #2755

ddfisher opened this issue Jan 25, 2017 · 5 comments
Labels
priority-2-low topic-tests topic-typed-dict

Comments

@ddfisher
Copy link
Collaborator

Many of the TypedDict tests in mypy/test/testextensions.py don't actually typecheck, even under 3.6 with the eval'd code placed properly in the codebase. This likely indicates a problem with the tests, as the constructs used are intended to typecheck. This is also the only remaining part of mypy that isn't fully typechecked.
@ddfisher
Copy link
Collaborator Author

@ilevkivskyi, would you mind taking a look at this at some point?

@ilevkivskyi
Copy link
Member

Yes, I will try to fix this.

@ilevkivskyi
Copy link
Member

This depends on python/typeshed#990 and #2492. After these two will be fixed, this one should be easy.

@ilevkivskyi ilevkivskyi self-assigned this Mar 31, 2017
@ilevkivskyi ilevkivskyi mentioned this issue Oct 9, 2017
Merged
@ilevkivskyi ilevkivskyi removed their assignment Dec 9, 2019
@97littleleaf11
Copy link
Collaborator

It seems that we don't have mypy/test/testextensions.py any more. Has this issue been fixed already? @ilevkivskyi

@ilevkivskyi
Copy link
Member

Yes, I think this is not relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-2-low topic-tests topic-typed-dict
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ddfisher @97littleleaf11 @ilevkivskyi