Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect number of arguments in type signature should not be a fatal error #2685

Closed
ddfisher opened this issue Jan 13, 2017 · 0 comments · Fixed by #2689
Closed

Incorrect number of arguments in type signature should not be a fatal error #2685

ddfisher opened this issue Jan 13, 2017 · 0 comments · Fixed by #2689
Assignees
@ddfisher
Labels
feature priority-0-high

Comments

@ddfisher
Copy link
Collaborator

ddfisher commented Jan 13, 2017 •
edited
Loading

In the fast parser, this is considered a fatal parse error and no other errors are reported. In the old parser, it's a blocking parse error -- no further checks happen after parsing, but other parse errors are reported. The fast parser should at least support this behavior.
@ddfisher ddfisher changed the title Incorrect number of arguments in type signature should not be a blocking error Incorrect number of arguments in type signature should not be a fatal error Jan 13, 2017
@ddfisher ddfisher self-assigned this Jan 13, 2017
@ddfisher ddfisher mentioned this issue Jan 13, 2017
Merged
gvanrossum pushed a commit that referenced this issue Jan 17, 2017
@ddfisher @gvanrossum
Make most fastparser errors non-fatal (#2689)
9141362 
Instead of throwing an exception up to the parse function when encountering an error, the fast parser will now report it to the errors object and keep parsing. These errors are still considered blocking errors, so type checking will not continue past the parsing stage. This means that mypy will show you all your parse errors, instead of showing them to you one at a time as you fix them.

Fixes #2685.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddfisher ddfisher

Labels
feature priority-0-high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make most fastparser errors non-fatal python/mypy
2 participants
@ddfisher @JukkaL