-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[good-first-issue] Expose the change log via Sphinx docs #17717
Comments
I will try to solve this. |
Can I ask you a question about this part? I think you suggested two ways to include Question: Which is better for this project, markdown or rst. The below is my comparison of markdown and rst.
|
The trampoline file under
I don't think it's a problem. The docs are usually built in one environment, with no need to support multiple variants of transitive deps. |
Then, I will go for Thank you for your help. |
I don't think this feature is very important. |
Fair |
I was browsing https://mypy.rtfd.io and was trying to find the change log, the search didn't find anything useful and I ended up locating it in the repository @ https://github.com/python/mypy/blob/master/CHANGELOG.md. But it was rather frustrating.
It is usually possible to show the same change log document in Sphinx. The challenge here is that it's in Markdown and Sphinx isn't set up to stomach it.
The solution is integrating
MyST-parser
by adding it to https://github.com/python/mypy/blob/fe15ee6/docs/requirements-docs.txt and https://github.com/python/mypy/blob/fe15ee6/docs/source/conf.py#L38, followed by creating achangelog.md
inside https://github.com/python/mypy/tree/fe15ee6/docs/source/ containing something like https://myst-parser.readthedocs.io/en/latest/faq/index.html#include-a-file-from-outside-the-docs-folder-like-readme-md. Though, it can bechangelog.rst
too (https://myst-parser.readthedocs.io/en/latest/faq/index.html#include-markdown-files-into-an-rst-file).Finally, a
changelog
entry needs to be added to ToC around https://github.com/python/mypy/blob/fe15ee6/docs/source/index.rst?plain=1#L99C4-L105C7.P.S. While writing this, I realized that https://mypy-lang.org does not have a change log link either. I don't know where its source is but it'd be nice to link the Sphinx-exposed change log page from that too.
The text was updated successfully, but these errors were encountered: