pre-commit-hooks is not needed to run tests using tox

[mtelka]

Bug Report

The tox.ini file specifies via the test-requirements.txt file that pre-commit-hooks is needed to run tests, but that's not the case for testing invoked using the tox command.

To Reproduce

Run tox without the pre-commit-hooks installed and all tests will pass.

Expected Behavior

pre-commit-hooks is not listed as dependency for tox testing.

Actual Behavior

pre-commit-hooks is needed for tox testing.

Your Environment

• Mypy version used: 1.4.1
• Mypy command-line flags: N/A
• Mypy configuration options from mypy.ini (and other config files): N/A
• Python version used: N/A

[AlexWaygood]

It's not required to run the tests, no, but it's included in case contributors want to manually run any of the hooks locally, e.g. by invoking trailing-whitespace some_file_i_changed.test. Does it cause any problems for it to be included in test-requirements.txt?

[mtelka]

I'm packaging mypy for OpenIndiana and during packaging we run tests. Usually using tox. To be able to do that we need to satisfy testing dependencies listed in tox.ini. In this case we either need the pre-commit-hooks package installed (we do not have pre-commit-hooks packaged yet for OpenIndiana), or patch it out from test-requirements.txt (we do this). This creates small maintenance burden, but not a big deal. The removal of pre-commit-hooks from test-requirements.txt would allow us to drop a patch from our build recipe. Not critical, just nice to have improvement for us. Thank you.