-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.970 planning #13089
Comments
Two typeshed things we need to include in the release: |
I'd like to plug my enum PR here: It fixes a false-positive error that was introduced a few releases back, and it's a very simple fix. It would allow me to correct the typeshed stubs for This PR (not by me) purports to fix two open crash reports, and also looks quite simple: @JukkaL's already reviewed this one (also not by me) and said it was basically ready to go in: |
I have cut the release branch https://github.com/python/mypy/commits/release-0.970 at 9f99400 (this includes the above fixes). |
Awesome, thank you! |
Also, thoughts on making this the last release to support 3.6? typeshed will be dropping support soon, python/typeshed#6189 is the relevant issue |
Is there a fix for that regression yet? I don't want to delay this release (I want to do it this week). Also don't have any opinion on Python 3.6, @JukkaL what do you think? |
(I can confirm that typeshed has now dropped support for 3.6 as of this morning: python/typeshed#8269.) |
Yeah, this will be the last version with full 3.6 support. I think that we can (and should) still continue to maintain Python feature availability checks for 3.6 and earlier. |
OK, I can include an announcement in the blog post. |
No fix yet for the regression, unfortunately. I'm on vacation, so I won't have the time to fix it soon. |
Would it be possible to have python/typeshed#8295 cherry-picked? It would be annoying to have to wait until the next mypy release, and it's pretty low-risk. |
I'd appreciate if PR #13144 could be cherry-picked. It won't affect the vast majority of users as it only affects mypyc, and it would unblock compilation of Black with latest mypy[c]. We could use mypy[c] from source, but things are simpler if we can pull from PyPI. Thanks in advance! (regardless if it's cherry-picked or not!) |
Backports for the above mentioned things: cc @ilevkivskyi |
Merged all three. |
Opened a fix for the regression #13161 (regression issue #12956 , regressed by #11143 ) cc @ilevkivskyi Would love for this to make the release. pandas and django-stubs are starting to use stubtest and they'll get bitten by this if it's regressed in the release. |
Thanks to ethanhs for reviewing! Here's the backport to 0.970 for the fix: #13162 |
Since @ilevkivskyi won't be available this week, I will finish the release process. |
The wheel builds are broken on macOS, and this is currently blocking the release: https://github.com/mypyc/mypy_mypyc-wheels/actions #13161 may have broken them, but it's still unclear. If I can't figure out how to fix it soon, I'll try reverting #13161. |
PR to fix the wheel builds: #13176 Once the wheel builds are fixed, I can make the release. Since I already pushed a commit to update mypy version to 0.970, the released version will actually have to be 0.971. |
Mypy 0.971 is out: https://mypy-lang.blogspot.com/2022/07/mypy-0971-released.html |
Let's hold off dropping Python 3.6 support until we know that there won't be a bugfix release. We might need 3.6 wheels for the bugfix release still. |
When will 0.980 be released? 😀 I was hoping for a newer version of typeshed. Looks like typeshed was picked from 14-Jun-2022, if I'm reading things correctly. I just wanted to voice hope for a 0.980 release with a newer typeshed soon. Thanks. |
@JohnVillalovos 0.980 will probably go out around mid August (if things go well). We can't make it earlier due to vacations etc. |
potential regression in mypyc: #13227 |
IIUC it is unlikely someone will fix these soon, so I think it would make sense to not make a point release, the next release should be soon anyway (~mid-August). |
Oh, wait, one of them is already fixed. Can we get a fix for the second? |
Any more discussion should probably be moved to #13385 |
I am planning to make a 0.970 release around mid July (or Jukka may overtake at some point).
Please post here any issues you'd like to see fixed in the release, or PRs you'd like to have merged. There is no release branch yet, but likely I will cut it from some if todays commits. So I would propose to only include critical PRs (e.g. regressions) on top.
The text was updated successfully, but these errors were encountered: