Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.970 planning #13089

Closed
ilevkivskyi opened this issue Jul 8, 2022 · 30 comments
Closed

Release 0.970 planning #13089

ilevkivskyi opened this issue Jul 8, 2022 · 30 comments
Labels
meta Issues tracking a broad area of work

Comments

@ilevkivskyi
Copy link
Member

I am planning to make a 0.970 release around mid July (or Jukka may overtake at some point).

Please post here any issues you'd like to see fixed in the release, or PRs you'd like to have merged. There is no release branch yet, but likely I will cut it from some if todays commits. So I would propose to only include critical PRs (e.g. regressions) on top.

@ilevkivskyi ilevkivskyi added the meta Issues tracking a broad area of work label Jul 8, 2022
@ilevkivskyi
Copy link
Member Author

@AlexWaygood
Copy link
Member

AlexWaygood commented Jul 8, 2022

I'd like to plug my enum PR here:

It fixes a false-positive error that was introduced a few releases back, and it's a very simple fix. It would allow me to correct the typeshed stubs for enum on Python 3.11, which currently aren't quite accurate.

This PR (not by me) purports to fix two open crash reports, and also looks quite simple:

@JukkaL's already reviewed this one (also not by me) and said it was basically ready to go in:

@ilevkivskyi
Copy link
Member Author

I have cut the release branch https://github.com/python/mypy/commits/release-0.970 at 9f99400 (this includes the above fixes).

@AlexWaygood
Copy link
Member

I have cut the release branch https://github.com/python/mypy/commits/release-0.970 at 9f99400 (this includes the above fixes).

Awesome, thank you!

@hauntsaninja
Copy link
Collaborator

This is a known regression on the 0.970 branch #12956 (caused by #11143 )

@hauntsaninja
Copy link
Collaborator

Also, thoughts on making this the last release to support 3.6? typeshed will be dropping support soon, python/typeshed#6189 is the relevant issue

@ilevkivskyi
Copy link
Member Author

Is there a fix for that regression yet? I don't want to delay this release (I want to do it this week). Also don't have any opinion on Python 3.6, @JukkaL what do you think?

@AlexWaygood
Copy link
Member

(I can confirm that typeshed has now dropped support for 3.6 as of this morning: python/typeshed#8269.)

@JukkaL
Copy link
Collaborator

JukkaL commented Jul 11, 2022

Yeah, this will be the last version with full 3.6 support. I think that we can (and should) still continue to maintain Python feature availability checks for 3.6 and earlier.

@ilevkivskyi
Copy link
Member Author

OK, I can include an announcement in the blog post.

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Jul 11, 2022

No fix yet for the regression, unfortunately. I'm on vacation, so I won't have the time to fix it soon.

@AlexWaygood
Copy link
Member

Would it be possible to have python/typeshed#8295 cherry-picked? It would be annoying to have to wait until the next mypy release, and it's pretty low-risk.

@ichard26
Copy link
Collaborator

I'd appreciate if PR #13144 could be cherry-picked. It won't affect the vast majority of users as it only affects mypyc, and it would unblock compilation of Black with latest mypy[c]. We could use mypy[c] from source, but things are simpler if we can pull from PyPI. Thanks in advance! (regardless if it's cherry-picked or not!)

@hauntsaninja
Copy link
Collaborator

Backports for the above mentioned things:

#13149
#13150
#13151

cc @ilevkivskyi

@ilevkivskyi
Copy link
Member Author

Merged all three.

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Jul 17, 2022

Opened a fix for the regression #13161 (regression issue #12956 , regressed by #11143 ) cc @ilevkivskyi

Would love for this to make the release. pandas and django-stubs are starting to use stubtest and they'll get bitten by this if it's regressed in the release.

@hauntsaninja
Copy link
Collaborator

Thanks to ethanhs for reviewing! Here's the backport to 0.970 for the fix: #13162

@JukkaL
Copy link
Collaborator

JukkaL commented Jul 18, 2022

Since @ilevkivskyi won't be available this week, I will finish the release process.

@JukkaL
Copy link
Collaborator

JukkaL commented Jul 18, 2022

The wheel builds are broken on macOS, and this is currently blocking the release: https://github.com/mypyc/mypy_mypyc-wheels/actions

#13161 may have broken them, but it's still unclear. If I can't figure out how to fix it soon, I'll try reverting #13161.

cc @hauntsaninja

@JukkaL
Copy link
Collaborator

JukkaL commented Jul 18, 2022

#13161 may have broken them, but it's still unclear.

#13161 caused the wheel build breakage, and the issue can be reproduced locally on macOS: #13174

@JukkaL
Copy link
Collaborator

JukkaL commented Jul 18, 2022

PR to fix the wheel builds: #13176

Once the wheel builds are fixed, I can make the release. Since I already pushed a commit to update mypy version to 0.970, the released version will actually have to be 0.971.

@JukkaL
Copy link
Collaborator

JukkaL commented Jul 19, 2022

Mypy 0.971 is out: https://mypy-lang.blogspot.com/2022/07/mypy-0971-released.html

@JukkaL
Copy link
Collaborator

JukkaL commented Jul 19, 2022

Let's hold off dropping Python 3.6 support until we know that there won't be a bugfix release. We might need 3.6 wheels for the bugfix release still.

@JohnVillalovos
Copy link

When will 0.980 be released? 😀 I was hoping for a newer version of typeshed. Looks like typeshed was picked from 14-Jun-2022, if I'm reading things correctly. I just wanted to voice hope for a 0.980 release with a newer typeshed soon. Thanks.

@JukkaL
Copy link
Collaborator

JukkaL commented Jul 19, 2022

@JohnVillalovos 0.980 will probably go out around mid August (if things go well). We can't make it earlier due to vacations etc.

@hauntsaninja
Copy link
Collaborator

#13214 is a regression, opened #13223 to fix

@twoertwein
Copy link

potential regression in mypyc: #13227

@ilevkivskyi
Copy link
Member Author

IIUC it is unlikely someone will fix these soon, so I think it would make sense to not make a point release, the next release should be soon anyway (~mid-August).

@ilevkivskyi
Copy link
Member Author

Oh, wait, one of them is already fixed. Can we get a fix for the second?

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Aug 21, 2022

Any more discussion should probably be moved to #13385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues tracking a broad area of work
Projects
None yet
Development

No branches or pull requests

7 participants