Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port bugfixes and enhancements to CPython (4.8.x). #360

Closed
jaraco opened this issue Dec 16, 2021 · 2 comments
Closed

Port bugfixes and enhancements to CPython (4.8.x). #360

jaraco opened this issue Dec 16, 2021 · 2 comments

Comments

@jaraco
Copy link
Member

jaraco commented Dec 16, 2021

I realize this change needs a port to CPython, but so also does 4.6.4 and later. I'm unsure if the changes from 4.7 and 4.8 can be safely backported in CPython, so I'll probably need to introduce those changes and the bugfix changes separately.

Originally posted by @jaraco in #357 (comment)

@jaraco
Copy link
Member Author

jaraco commented Dec 16, 2021

I can see a couple of ways to accomplish the above:

  1. Cherry-pick the bugfixes into the cpython branch and apply those to CPython, then apply the enhancements in a separate PR.
  2. Apply all the changes to the CPython branch, but when doing the backports to older Pythons, back out the enhancement changes.
  3. Apply changes to CPython in multiple rounds, in the order they were released here, with enhancements and bugfixes separated (e.g. 4.6.4, 4.7.0, 4.7.1, 4.8.0, 4.8.3).

Now that I look at it, the bugfixes 4.6.4 and 4.7.1 and 4.8.1 are not particularly important to CPython. So it looks like I can merge 4.8.1 into cpython, then merge 4.8.3 and backport that.

@jaraco
Copy link
Member Author

jaraco commented Dec 17, 2021

Fixed in bpo-46105 and bpo-44893.

@jaraco jaraco closed this as completed Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant