Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations #10

Closed
jaraco opened this issue Oct 22, 2020 · 12 comments
Closed

Add type annotations #10

jaraco opened this issue Oct 22, 2020 · 12 comments
Labels

Comments

@jaraco
Copy link
Member

jaraco commented Oct 22, 2020

In GitLab by @warsaw on Sep 11, 2018, 24:35

For Python 3 only.

@jaraco jaraco added the api label Oct 22, 2020
@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @warsaw on Sep 14, 2018, 15:49

I'm deferring this to 0.4. I think once #9 is approved and landed, I'll do the 0.3 release and announce it. At that point we should be more or less feature complete I think.

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @warsaw on Sep 18, 2018, 24:27

mentioned in merge request !18

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Oct 7, 2018, 14:07

assigned to @warsaw

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Oct 7, 2018, 14:14

@warsaw, do you want to do this for the 0.6 release or push it out to another release? I've not used type annotations much, so I'd appreciate if you'd take the first cut at it and I can use that work to improve my understanding. I think this work should be simpler now that much of the module logic has been stripped out.

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Oct 7, 2018, 14:20

Now that I think about it, I'd like to get 0.6 out, so I'll push this out to the next milestone. We can get to it at any point.

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Nov 27, 2018, 17:21

removed milestone

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @warsaw on May 6, 2019, 19:44

After discussing at Pycon 2019, we decided to use .pyi files here, which can be contributed to typeshed and not include in CPython. That way, we can run mypy over this repository, verifying that our annotations are correct, even though mypy is not integrated with CPython workflow.

We would ship the .pyi file with this distribution and not port it over to CPython. Then when we invert after 3.8 is released, we would just have to keep this repo updated with any typing changes.

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @warsaw on May 6, 2019, 19:45

assigned to @gahjelle and unassigned @warsaw

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @gahjelle on May 7, 2019, 19:49

mentioned in merge request !59

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @warsaw on Jun 7, 2019, 21:08

I'm deferring this past 1.0 (i.e. Python 3.8 final).

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Jan 26, 2020, 16:43

removed milestone

@jaraco
Copy link
Member Author

jaraco commented Jan 10, 2021

I'm declaring this done as the project runs typechecks against the code base which has some type declarations. Improvements welcome. I'll add a py.typed file.

@jaraco jaraco closed this as completed in b017516 Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant