Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93649: Split float/long tests from _testcapimodule.c #99549

Merged
merged 3 commits into from
Nov 17, 2022
Merged

gh-93649: Split float/long tests from _testcapimodule.c #99549

merged 3 commits into from
Nov 17, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Nov 16, 2022 •
edited by miss-islington
Loading

Automerge-Triggered-By: GH:erlend-aasland

@erlend-aasland erlend-aasland requested a review from a team as a code owner November 16, 2022 21:28
@bedevere-bot bedevere-bot mentioned this pull request Nov 16, 2022
Open
vstinner
vstinner approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erlend-aasland
Copy link
Contributor Author

Thanks for the review!

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: 5 of 7 required status checks are expected..

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 12b5a3c into python:main Nov 17, 2022
@erlend-aasland erlend-aasland deleted the split-testcapi/numbers branch November 17, 2022 09:10
@encukou encukou mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @miss-islington @vstinner @bedevere-bot