Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-83004: Clean up refleak in _zoneinfo initialisation #98842

Merged
merged 4 commits into from
Nov 6, 2022
Merged

gh-83004: Clean up refleak in _zoneinfo initialisation #98842

merged 4 commits into from
Nov 6, 2022

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Oct 29, 2022 •
edited by bedevere-bot
Loading

@JelleZijlstra
Copy link
Member

Code looks good, but I think we need a NEWS entry as this fixes a (very unlikely) user-facing issue.

@bedevere-bot bedevere-bot mentioned this pull request Nov 2, 2022
Closed
@hauntsaninja
Copy link
Contributor Author

Added the NEWS entry. If you want to review other changes like this, there's #98840 and #98841

I also went through CPython and about 20 other modules are affected. Should I continue to do single module PRs or can I batch them?

@JelleZijlstra
Copy link
Member

Thanks! I think batching them is fine since the change is simple.

@JelleZijlstra JelleZijlstra self-assigned this Nov 3, 2022
@JelleZijlstra JelleZijlstra merged commit 31f2f65 into python:main Nov 6, 2022
@miss-islington
Copy link
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2022
@hauntsaninja @miss-islington
pythongh-83004: Clean up refleak in _zoneinfo initialisation (pythonG…
aadf057 
…H-98842)

(cherry picked from commit 31f2f65)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@bedevere-bot
Copy link

GH-99163 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 6, 2022
@bedevere-bot
Copy link

GH-99164 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 6, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2022
@hauntsaninja @miss-islington
pythongh-83004: Clean up refleak in _zoneinfo initialisation (pythonG…
7cf8db3 
…H-98842)

(cherry picked from commit 31f2f65)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Nov 6, 2022
@miss-islington @hauntsaninja
gh-83004: Clean up refleak in _zoneinfo initialisation (GH-98842)
4b1e45e 
(cherry picked from commit 31f2f65)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Nov 6, 2022
@miss-islington @hauntsaninja
gh-83004: Clean up refleak in _zoneinfo initialisation (GH-98842)
70006d6 
(cherry picked from commit 31f2f65)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@hauntsaninja hauntsaninja deleted the gh-83004-zoneinfo branch November 21, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@pganssle pganssle Awaiting requested review from pganssle

Assignees

@JelleZijlstra JelleZijlstra

Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hauntsaninja @JelleZijlstra @miss-islington @bedevere-bot