Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] gh-98517: Fix buffer overflows in _sha3 module (GH-98519) #98527

Merged
merged 1 commit into from
Oct 28, 2022
Merged

[3.8] gh-98517: Fix buffer overflows in _sha3 module (GH-98519) #98527

merged 1 commit into from
Oct 28, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 21, 2022 •
edited by bedevere-bot
Loading

This is a port of the applicable part of XKCP's fix 1 for
CVE-2022-37454 and avoids the segmentation fault and the infinite
loop in the test cases published in 2.

Regression test added by: Gregory P. Smith [Google LLC] greg@krypto.org
(cherry picked from commit 0e4e058)

Co-authored-by: Theo Buehler botovq@users.noreply.github.com

@botovq @miss-islington
[3.10] pythongh-98517: Fix buffer overflows in _sha3 module (pythonGH…
64ab634 
…-98519)

This is a port of the applicable part of XKCP's fix [1] for
CVE-2022-37454 and avoids the segmentation fault and the infinite
loop in the test cases published in [2].

[1]: XKCP/XKCP@fdc6fef
[2]: https://mouha.be/sha-3-buffer-overflow/

Regression test added by: Gregory P. Smith [Google LLC] <greg@krypto.org>
(cherry picked from commit 0e4e058)

Co-authored-by: Theo Buehler <botovq@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this pull request Oct 21, 2022
Merged
@bedevere-bot bedevere-bot added type-crash A hard crash of the interpreter, possibly with a core dump type-security A security issue labels Oct 21, 2022
@gpshead gpshead changed the title [3.8] [3.10] gh-98517: Fix buffer overflows in _sha3 module (GH-98519) [3.8] gh-98517: Fix buffer overflows in _sha3 module (GH-98519) Oct 21, 2022
@gpshead gpshead added the 3.8 (EOL) end of life label Oct 21, 2022
@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@ambv ambv merged commit 948c679 into python:3.8 Oct 28, 2022
@miss-islington miss-islington deleted the backport-0e4e058-3.8 branch October 28, 2022 10:07
@stefanor stefanor mentioned this pull request Oct 29, 2022
Closed
@arhadthedev arhadthedev mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees

@ambv ambv

Labels
3.8 (EOL) end of life release-blocker type-crash A hard crash of the interpreter, possibly with a core dump type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @gpshead @ambv @bedevere-bot @botovq