Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-97747: Improvements to WASM browser REPL. #97665

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

katharosada
Copy link
Contributor

@katharosada katharosada commented Sep 30, 2022

Adds a text box to write and run code outside the REPL, a stop button, and handling of Ctrl-D for EOF.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Sep 30, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@katharosada katharosada changed the title Improvements to WASM browser REPL. gh-97747: Improvements to WASM browser REPL. Oct 3, 2022
Adds a text box to write and run code outside the REPL, a stop button, and handling of Ctrl-D for EOF.
@treyhunner
Copy link
Member

Confirmed that these changes work as expected.

This just helped me implement Ctrl+D in the in-browser REPL at https://pym.dev/r, which has been a long-standing bug in that REPL for a while.

Thank you @katharosada!

@ambv ambv merged commit 010aaa3 into python:main May 31, 2024
@ambv ambv added the needs backport to 3.13 bugs and security fixes label May 31, 2024
@miss-islington-app
Copy link

Thanks @katharosada for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2024
Improvements to WASM browser REPL.

Adds a text box to write and run code outside the REPL, a stop button, and handling of Ctrl-D for EOF.
(cherry picked from commit 010aaa3)

Co-authored-by: Katie Bell <katie@katharos.id.au>
@bedevere-app
Copy link

bedevere-app bot commented May 31, 2024

GH-119828 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 31, 2024
ambv pushed a commit that referenced this pull request May 31, 2024
…9828)

(cherry picked from commit 010aaa3)

Co-authored-by: Katie Bell <katie@katharos.id.au>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
Improvements to WASM browser REPL.

Adds a text box to write and run code outside the REPL, a stop button, and handling of Ctrl-D for EOF.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Improvements to WASM browser REPL.

Adds a text box to write and run code outside the REPL, a stop button, and handling of Ctrl-D for EOF.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants