Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34900: Fix subTests to not crash when called from TestCase.debug() #9707

Merged
merged 2 commits into from
Oct 12, 2018
Merged

bpo-34900: Fix subTests to not crash when called from TestCase.debug() #9707

merged 2 commits into from
Oct 12, 2018

Conversation

nicoddemus
Copy link
Contributor

@nicoddemus nicoddemus commented Oct 4, 2018 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

This was referenced Oct 4, 2018
Closed
Open
berkerpeksag
berkerpeksag requested changes Oct 5, 2018
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a NEWS entry. See https://devguide.python.org/committing/#what-s-new-and-news-entries for details.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@nicoddemus nicoddemus force-pushed the subtests-debug-34900 branch from 3d256b4 to f2b7b71 Compare October 5, 2018 08:59
@nicoddemus
Copy link
Contributor Author

Thanks @berkerpeksag for the quick review.

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

@nicoddemus nicoddemus force-pushed the subtests-debug-34900 branch from f2b7b71 to eddd087 Compare October 5, 2018 09:15
nicoddemus
nicoddemus commented Oct 5, 2018
View reviewed changes
Misc/NEWS.d/next/Library/2018-10-05-05-55-53.bpo-34900.8RNiFu.rst
@@ -1,2 +1,2 @@
Fixed ``TestCase.debug()`` when used to call test methods with subtests.
Patch by Bruno Oliveira.
Fixed :meth:`unittest.TestCase.debug` when used to call test methods with
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicoddemus
Copy link
Contributor Author

Hi @berkerpeksag, gentle ping that CLA has been signed. 👍

@berkerpeksag berkerpeksag merged commit da2bf9f into python:master Oct 12, 2018
@miss-islington
Copy link
Contributor

Thanks @nicoddemus for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-9818 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2018
@nicoddemus @miss-islington
bpo-34900: Make TestCase.debug() work with subtests (pythonGH-9707)
4d95f5b 
(cherry picked from commit da2bf9f)

Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2018
@nicoddemus @miss-islington
bpo-34900: Make TestCase.debug() work with subtests (pythonGH-9707)
cdb2f08 
(cherry picked from commit da2bf9f)

Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
@bedevere-bot
Copy link

GH-9819 is a backport of this pull request to the 3.6 branch.

@berkerpeksag
Copy link
Member

Thanks!

@nicoddemus nicoddemus deleted the subtests-debug-34900 branch October 12, 2018 10:47
berkerpeksag pushed a commit that referenced this pull request Oct 12, 2018
@miss-islington @nicoddemus @berkerpeksag
bpo-34900: Make TestCase.debug() work with subtests (GH-9707)
7a98e30 
(cherry picked from commit da2bf9f)

Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
berkerpeksag pushed a commit that referenced this pull request Oct 12, 2018
@miss-islington @nicoddemus @berkerpeksag
bpo-34900: Make TestCase.debug() work with subtests (GH-9707)
c1fe49c 
(cherry picked from commit da2bf9f)

Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicoddemus @the-knights-who-say-ni @bedevere-bot @miss-islington @berkerpeksag