Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-96975: Skip incomplete frames in PyEval_GetFrame #97003

Merged
merged 4 commits into from
Sep 22, 2022
Merged

GH-96975: Skip incomplete frames in PyEval_GetFrame #97003

merged 4 commits into from
Sep 22, 2022

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Sep 21, 2022 •
edited by bedevere-bot
Loading

@brandtbucher brandtbucher added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.11 only security fixes labels Sep 21, 2022
@brandtbucher brandtbucher self-assigned this Sep 21, 2022
ericsnowcurrently
ericsnowcurrently approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

I've left a few minor comments but leave it to you to decide.

(I'm approving under the assumption you will get it right before merging.)

ericsnowcurrently
ericsnowcurrently approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandtbucher brandtbucher merged commit 8fd2c3b into python:main Sep 22, 2022
@miss-islington
Copy link
Contributor

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-97018 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 22, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2022
@brandtbucher @miss-islington
pythonGH-96975: Skip incomplete frames in PyEval_GetFrame (pythonGH-9…
3f60d68 
…7003)

(cherry picked from commit 8fd2c3b)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@brandtbucher brandtbucher

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandtbucher @miss-islington @bedevere-bot @ericsnowcurrently