Skip to content

Improvements to typing documentation #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2017
Merged

Improvements to typing documentation #967

merged 4 commits into from
Apr 8, 2017

Conversation

JelleZijlstra
Copy link
Member

Documents a few omitted classes and adds NamedTuple methods.

@ilevkivskyi would you mind reviewing this?

@JelleZijlstra
Improvements to typing documentation
f75578d 
Documents a few omitted classes and adds NamedTuple methods.
@JelleZijlstra
clarify statement
b268bb4
@mention-bot
Copy link

@JelleZijlstra, thanks for your PR! By analyzing the history of the files in this pull request, we identified @berkerpeksag, @zware and @brettcannon to be potential reviewers.

@JelleZijlstra JelleZijlstra mentioned this pull request Apr 3, 2017
Closed
@JelleZijlstra
Copy link
Member Author

The Travis failure appears to be a Sphinx bug. Reported as sphinx-doc/sphinx#3600.

@Mariatta Mariatta added needs backport to 3.6 docs Documentation in the Doc dir labels Apr 3, 2017
@DimitrisJim
Copy link
Contributor

Indeed, it was already reported at sphinx-doc/sphinx#3597, waiting for sphinx-doc/sphinx#3598 to be resolved.

ilevkivskyi
ilevkivskyi approved these changes Apr 3, 2017
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for PR! This looks good to me.

(I have noticed inconsistent formatting (number of leading spaces), but I think there should be a separate PR fixing it in the whole file.)

@rhettinger
Copy link
Contributor

LGTM

@berkerpeksag berkerpeksag merged commit 45d22c2 into python:master Apr 8, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Apr 9, 2017
@JelleZijlstra @Mariatta
[3.6] Improvements to typing documentation (pythonGH-967)
d2998e6 
Documents a few omitted classes and adds NamedTuple methods.
(cherry picked from commit 45d22c2)
Mariatta added a commit that referenced this pull request Apr 9, 2017
@Mariatta
[3.6] Improvements to typing documentation (GH-967) (GH-1053)
28ddd3c 
Documents a few omitted classes and adds NamedTuple methods.
(cherry picked from commit 45d22c2)
@JelleZijlstra JelleZijlstra deleted the patch-6 branch April 13, 2017 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JelleZijlstra @mention-bot @DimitrisJim @rhettinger @berkerpeksag @ilevkivskyi @Mariatta @the-knights-who-say-ni