Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96320: WASI socket fixes #96388

Merged
merged 2 commits into from
Aug 30, 2022
Merged

gh-96320: WASI socket fixes #96388

merged 2 commits into from
Aug 30, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Aug 29, 2022 •
edited by bedevere-bot
Loading

  • ignore missing functions in socket.__repr__
  • bundle network files with assets

@tiran
pythongh-96320: WASI socket fixes
6f070cf 
- ignore missing functions in ``socket.__repr__``
- bundle network files with assets
@tiran tiran force-pushed the gh-96320-wasi-socket branch from 41bd31d to 6f070cf Compare August 29, 2022 14:53
@tiran tiran requested a review from brettcannon August 29, 2022 14:56
@tiran tiran merged commit d0b3d23 into python:main Aug 30, 2022
@tiran tiran deleted the gh-96320-wasi-socket branch September 11, 2022 08:01
@tiran tiran added the needs backport to 3.11 only security fixes label Sep 11, 2022
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2022
@tiran @miss-islington
pythongh-96320: WASI socket fixes (pythonGH-96388)
db0366b 
* pythongh-96320: WASI socket fixes

- ignore missing functions in ``socket.__repr__``
- bundle network files with assets

* blurb
(cherry picked from commit d0b3d23)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

GH-96748 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 11, 2022
tiran pushed a commit that referenced this pull request Sep 13, 2022
@miss-islington
[3.11] gh-96320: WASI socket fixes (GH-96388) (GH-#96748)
390123b 
- ignore missing functions in ``socket.__repr__``
- bundle network files with assets
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.11 has failed when building commit 390123b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1007/builds/394) and take a look at the build logs.
  4. Check if the failure is related to this commit (390123b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1007/builds/394

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

416 tests OK.

10 slowest tests:

  • test_tools: 11 min 4 sec
  • test_multiprocessing_spawn: 5 min 14 sec
  • test_tokenize: 4 min 12 sec
  • test_asyncio: 4 min 6 sec
  • test_concurrent_futures: 3 min 8 sec
  • test_capi: 2 min 45 sec
  • test_multiprocessing_forkserver: 2 min 8 sec
  • test_unparse: 2 min 5 sec
  • test_mailbox: 1 min 50 sec
  • test_multiprocessing_fork: 1 min 42 sec

1 test altered the execution environment:
test_asyncio

19 tests skipped:
test_dbm_ndbm test_devpoll test_gdb test_idle test_ioctl
test_kqueue test_launcher test_msilib test_startfile test_tcl
test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 43 min 19 sec

Click to see traceback logs 
remote: Enumerating objects: 43, done.        
remote: Counting objects:   2% (1/38)        
remote: Counting objects:   5% (2/38)        
remote: Counting objects:   7% (3/38)        
remote: Counting objects:  10% (4/38)        
remote: Counting objects:  13% (5/38)        
remote: Counting objects:  15% (6/38)        
remote: Counting objects:  18% (7/38)        
remote: Counting objects:  21% (8/38)        
remote: Counting objects:  23% (9/38)        
remote: Counting objects:  26% (10/38)        
remote: Counting objects:  28% (11/38)        
remote: Counting objects:  31% (12/38)        
remote: Counting objects:  34% (13/38)        
remote: Counting objects:  36% (14/38)        
remote: Counting objects:  39% (15/38)        
remote: Counting objects:  42% (16/38)        
remote: Counting objects:  44% (17/38)        
remote: Counting objects:  47% (18/38)        
remote: Counting objects:  50% (19/38)        
remote: Counting objects:  52% (20/38)        
remote: Counting objects:  55% (21/38)        
remote: Counting objects:  57% (22/38)        
remote: Counting objects:  60% (23/38)        
remote: Counting objects:  63% (24/38)        
remote: Counting objects:  65% (25/38)        
remote: Counting objects:  68% (26/38)        
remote: Counting objects:  71% (27/38)        
remote: Counting objects:  73% (28/38)        
remote: Counting objects:  76% (29/38)        
remote: Counting objects:  78% (30/38)        
remote: Counting objects:  81% (31/38)        
remote: Counting objects:  84% (32/38)        
remote: Counting objects:  86% (33/38)        
remote: Counting objects:  89% (34/38)        
remote: Counting objects:  92% (35/38)        
remote: Counting objects:  94% (36/38)        
remote: Counting objects:  97% (37/38)        
remote: Counting objects: 100% (38/38)        
remote: Counting objects: 100% (38/38), done.        
remote: Compressing objects:   3% (1/31)        
remote: Compressing objects:   6% (2/31)        
remote: Compressing objects:   9% (3/31)        
remote: Compressing objects:  12% (4/31)        
remote: Compressing objects:  16% (5/31)        
remote: Compressing objects:  19% (6/31)        
remote: Compressing objects:  22% (7/31)        
remote: Compressing objects:  25% (8/31)        
remote: Compressing objects:  29% (9/31)        
remote: Compressing objects:  32% (10/31)        
remote: Compressing objects:  35% (11/31)        
remote: Compressing objects:  38% (12/31)        
remote: Compressing objects:  41% (13/31)        
remote: Compressing objects:  45% (14/31)        
remote: Compressing objects:  48% (15/31)        
remote: Compressing objects:  51% (16/31)        
remote: Compressing objects:  54% (17/31)        
remote: Compressing objects:  58% (18/31)        
remote: Compressing objects:  61% (19/31)        
remote: Compressing objects:  64% (20/31)        
remote: Compressing objects:  67% (21/31)        
remote: Compressing objects:  70% (22/31)        
remote: Compressing objects:  74% (23/31)        
remote: Compressing objects:  77% (24/31)        
remote: Compressing objects:  80% (25/31)        
remote: Compressing objects:  83% (26/31)        
remote: Compressing objects:  87% (27/31)        
remote: Compressing objects:  90% (28/31)        
remote: Compressing objects:  93% (29/31)        
remote: Compressing objects:  96% (30/31)        
remote: Compressing objects: 100% (31/31)        
remote: Compressing objects: 100% (31/31), done.        
remote: Total 43 (delta 11), reused 17 (delta 7), pack-reused 5        
From https://github.com/python/cpython
 * branch                  3.11       -> FETCH_HEAD
Note: switching to '390123b412346eb4438665f068bb73226ac84e7c'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 390123b412 [3.11] gh-96320: WASI socket fixes (GH-96388) (GH-#96748)
Switched to and reset branch '3.11'

configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

renaming build/scripts-3.11/pydoc3 to build/scripts-3.11/pydoc3.11
renaming build/scripts-3.11/idle3 to build/scripts-3.11/idle3.11
renaming build/scripts-3.11/2to3 to build/scripts-3.11/2to3-3.11

renaming build/scripts-3.11/pydoc3 to build/scripts-3.11/pydoc3.11
renaming build/scripts-3.11/idle3 to build/scripts-3.11/idle3.11
renaming build/scripts-3.11/2to3 to build/scripts-3.11/2to3-3.11

renaming build/scripts-3.11/pydoc3 to build/scripts-3.11/pydoc3.11
renaming build/scripts-3.11/idle3 to build/scripts-3.11/idle3.11
renaming build/scripts-3.11/2to3 to build/scripts-3.11/2to3-3.11
make: *** [Makefile:1841: buildbottest] Error 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @miss-islington @bedevere-bot @brettcannon