bpo-34521: Fix tests in test_multiprocessing_spawn to use correctly CMSG_SPACE #9613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MSG_SPACE After some failures in AMD64 FreeBSD CURRENT Debug 3.x buildbots regarding tests in test_multiprocessing_spawn and after examining similar failures in test_socket, some errors in the calculation of ancillary data buffers were found in multiprocessing.reduction. CMSG_LEN() can often be used as the buffer size for recvmsg() to receive a single item of ancillary data, but RFC 3542 requires portable applications to use CMSG_SPACE() and thus include space for padding, even when the item will be the last in the buffer. The failures we experience are due to the usage of CMSG_LEN instead of CMSG_SPACE.
|
Tested on the buildbot itself: CURRENT-amd64% uname -a
FreeBSD CURRENT-amd64 12.0-ALPHA6 FreeBSD 12.0-ALPHA6 r338678 amd64
CURRENT-amd64% ./python -m test test_multiprocessing_spawn
Run tests sequentially
0:00:00 load avg: 0.17 [1/1] test_multiprocessing_spawn
test_multiprocessing_spawn passed in 3 min 24 sec
== Tests result: SUCCESS ==
1 test OK.
Total duration: 3 min 24 sec
Tests result: SUCCESS |
|
I will wait for the FreeBSD CURRENT buildbot to see if it fixes the issue. If yes, we can backport the change. |
|
Thanks @pablogsal for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
Thanks @pablogsal for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 28, 2018
…MSG_SPACE (pythonGH-9613) After some failures in AMD64 FreeBSD CURRENT Debug 3.x buildbots regarding tests in test_multiprocessing_spawn and after examining similar failures in test_socket, some errors in the calculation of ancillary data buffers were found in multiprocessing.reduction. CMSG_LEN() can often be used as the buffer size for recvmsg() to receive a single item of ancillary data, but RFC 3542 requires portable applications to use CMSG_SPACE() and thus include space for padding, even when the item will be the last in the buffer. The failures we experience are due to the usage of CMSG_LEN() instead of CMSG_SPACE(). (cherry picked from commit 077061a) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
|
GH-9618 is a backport of this pull request to the 3.6 branch. |
|
GH-9619 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 28, 2018
…MSG_SPACE (pythonGH-9613) After some failures in AMD64 FreeBSD CURRENT Debug 3.x buildbots regarding tests in test_multiprocessing_spawn and after examining similar failures in test_socket, some errors in the calculation of ancillary data buffers were found in multiprocessing.reduction. CMSG_LEN() can often be used as the buffer size for recvmsg() to receive a single item of ancillary data, but RFC 3542 requires portable applications to use CMSG_SPACE() and thus include space for padding, even when the item will be the last in the buffer. The failures we experience are due to the usage of CMSG_LEN() instead of CMSG_SPACE(). (cherry picked from commit 077061a) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Sep 28, 2018
…MSG_SPACE (GH-9613) After some failures in AMD64 FreeBSD CURRENT Debug 3.x buildbots regarding tests in test_multiprocessing_spawn and after examining similar failures in test_socket, some errors in the calculation of ancillary data buffers were found in multiprocessing.reduction. CMSG_LEN() can often be used as the buffer size for recvmsg() to receive a single item of ancillary data, but RFC 3542 requires portable applications to use CMSG_SPACE() and thus include space for padding, even when the item will be the last in the buffer. The failures we experience are due to the usage of CMSG_LEN() instead of CMSG_SPACE(). (cherry picked from commit 077061a) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
vstinner
pushed a commit
that referenced
this pull request
Sep 28, 2018
…MSG_SPACE (GH-9613) (GH-9619) After some failures in AMD64 FreeBSD CURRENT Debug 3.x buildbots regarding tests in test_multiprocessing_spawn and after examining similar failures in test_socket, some errors in the calculation of ancillary data buffers were found in multiprocessing.reduction. CMSG_LEN() can often be used as the buffer size for recvmsg() to receive a single item of ancillary data, but RFC 3542 requires portable applications to use CMSG_SPACE() and thus include space for padding, even when the item will be the last in the buffer. The failures we experience are due to the usage of CMSG_LEN() instead of CMSG_SPACE(). (cherry picked from commit 077061a) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal
added a commit
that referenced
this pull request
Oct 14, 2018
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 15, 2018
* Add News entry for the change in multiprocessing.reduction.recvfds made in pythonGH-9613. (cherry picked from commit bd036d3) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 15, 2018
* Add News entry for the change in multiprocessing.reduction.recvfds made in pythonGH-9613. (cherry picked from commit bd036d3) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Oct 15, 2018
miss-islington
added a commit
that referenced
this pull request
Oct 16, 2018
ned-deily
pushed a commit
to ned-deily/cpython
that referenced
this pull request
Oct 20, 2018
* Add News entry for the change in multiprocessing.reduction.recvfds made in pythonGH-9613. (cherry picked from commit bd036d3) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
ned-deily
pushed a commit
to ned-deily/cpython
that referenced
this pull request
Oct 20, 2018
* Add News entry for the change in multiprocessing.reduction.recvfds made in pythonGH-9613. (cherry picked from commit bd036d3) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some failures in AMD64 FreeBSD CURRENT Debug 3.x buildbots
regarding tests in test_multiprocessing_spawn and after examining
similar failures in test_socket, some errors in the calculation of
ancillary data buffers were found in multiprocessing.reduction.
CMSG_LEN() can often be used as the buffer size for recvmsg() to
receive a single item of ancillary data, but RFC 3542 requires portable
applications to use CMSG_SPACE() and thus include space for padding,
even when the item will be the last in the buffer.
The failures we experience are due to the usage of CMSG_LEN instead of
CMSG_SPACE.
https://bugs.python.org/issue34521