gh-95273: Improve sqlite3.complete_statement docs by erlend-aasland · Pull Request #95840 · python/cpython

erlend-aasland · 2022-08-09T22:38:45Z

Issue: Improve the sqlite3 reference #95273

CAM-Gerlach

Two suggested changes. Otherwise, LGTM

Doc/library/sqlite3.rst

erlend-aasland · 2022-08-10T07:41:57Z

Thanks for the review, CAM; PTAL before I land this.

Doc/library/sqlite3.rst

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

CAM-Gerlach

LGTM otherwise, but I definitely think that the minimal example @ezio-melotti suggested would be very helpful to add here. I've made it as a suggestion.

Doc/library/sqlite3.rst

Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

CAM-Gerlach

A few trivial nits, but LGTM, thanks @erlend-aasland

Doc/library/sqlite3.rst

Lib/sqlite3/__main__.py

Doc/library/sqlite3.rst

erlend-aasland · 2022-08-11T21:08:18Z

Review comments addressed. I also relocated the example; I felt it made more sense to have it just after the first paragraph.

CAM-Gerlach

LGTM, thanks @erlend-aasland !

erlend-aasland · 2022-08-11T23:04:53Z

Thanks for the reviews! Now I'll fix sqlite3.complete_statement() so it correctly raises memory error on SQLITE_NO_MEM.

miss-islington · 2022-08-11T23:05:14Z

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington · 2022-08-11T23:05:35Z

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e6623e7083ce08a247e5df169bcc749f99327823 3.11

miss-islington · 2022-08-11T23:05:37Z

Sorry @erlend-aasland, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e6623e7083ce08a247e5df169bcc749f99327823 3.10

erlend-aasland · 2022-08-11T23:48:36Z

I'll fix the backports tomorrow.

…nGH-95840) Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>. (cherry picked from commit e6623e7) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

bedevere-bot · 2022-08-12T07:24:03Z

GH-95917 is a backport of this pull request to the 3.11 branch.

…nGH-95840) Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>. (cherry picked from commit e6623e7) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

bedevere-bot · 2022-08-12T07:29:54Z

GH-95918 is a backport of this pull request to the 3.10 branch.

…95917) Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>. (cherry picked from commit e6623e7) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

…95918) Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>. (cherry picked from commit e6623e7) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

pythongh-95273: Improve sqlite3.complete_statement docs

2d3b7f1

erlend-aasland requested a review from berkerpeksag as a code owner August 9, 2022 22:38

erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.10 only security fixes labels Aug 9, 2022

erlend-aasland requested a review from CAM-Gerlach August 9, 2022 22:38

bedevere-bot added the awaiting core review label Aug 9, 2022

erlend-aasland added the skip news label Aug 9, 2022

CAM-Gerlach reviewed Aug 10, 2022

View reviewed changes

Doc/library/sqlite3.rst Outdated Show resolved Hide resolved

Doc/library/sqlite3.rst Outdated Show resolved Hide resolved

Address review

31b60fb

ezio-melotti reviewed Aug 10, 2022

View reviewed changes

Doc/library/sqlite3.rst Outdated Show resolved Hide resolved

Doc/library/sqlite3.rst Outdated Show resolved Hide resolved

Typo

4c85590

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

CAM-Gerlach reviewed Aug 11, 2022

View reviewed changes

Doc/library/sqlite3.rst Outdated Show resolved Hide resolved

Erlend E. Aasland and others added 2 commits August 11, 2022 09:58

Address review: add trivial example

e612289

Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

Add comments to CLI so it serves better as an example

887879f

ezio-melotti approved these changes Aug 11, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Aug 11, 2022

CAM-Gerlach approved these changes Aug 11, 2022

View reviewed changes

Doc/library/sqlite3.rst Outdated Show resolved Hide resolved

Lib/sqlite3/__main__.py Outdated Show resolved Hide resolved

Doc/library/sqlite3.rst Outdated Show resolved Hide resolved

Address review and relocate example

44ddf4a

CAM-Gerlach approved these changes Aug 11, 2022

View reviewed changes

erlend-aasland merged commit e6623e7 into python:main Aug 11, 2022

bedevere-bot removed the awaiting merge label Aug 11, 2022

erlend-aasland deleted the sqlite-reference/complete-statement branch August 11, 2022 23:05

miss-islington assigned erlend-aasland Aug 11, 2022

bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 12, 2022

bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 12, 2022

erlend-aasland mentioned this pull request Aug 18, 2022

Improve the sqlite3 reference #95273

Closed

5 tasks

Uh oh!

Conversation

erlend-aasland commented Aug 9, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Aug 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Aug 11, 2022

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

erlend-aasland commented Aug 11, 2022

Uh oh!

miss-islington commented Aug 11, 2022

Uh oh!

miss-islington commented Aug 11, 2022

Uh oh!

miss-islington commented Aug 11, 2022

Uh oh!

erlend-aasland commented Aug 11, 2022

Uh oh!

bedevere-bot commented Aug 12, 2022

Uh oh!

bedevere-bot commented Aug 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

erlend-aasland commented Aug 9, 2022 •

edited by bedevere-bot

Loading

erlend-aasland commented Aug 10, 2022 •

edited

Loading