Skip to content

gh-93157: Fix fileinput didn't support errors in inplace mode #95128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2022
Merged

gh-93157: Fix fileinput didn't support errors in inplace mode #95128

merged 3 commits into from
Jul 24, 2022

Conversation

@methane
Copy link
Member

@methane methane commented Jul 22, 2022 •
edited by bedevere-bot
Loading

@methane methane added type-bug An unexpected behavior, bug, or error needs backport to 3.10 only security fixes stdlib Standard Library Python modules in the Lib/ directory needs backport to 3.11 only security fixes labels Jul 22, 2022
@methane methane linked an issue Jul 22, 2022 that may be closed by this pull request
fileinput with inplace=True ignores errors parameter #93157
Closed
@methane methane merged commit 5c7f3bc into python:main Jul 24, 2022
@methane methane deleted the fileinput-errors branch July 24, 2022 02:42
@miss-islington
Copy link
Contributor

miss-islington commented Jul 24, 2022

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 24, 2022

GH-95187 is a backport of this pull request to the 3.11 branch.

@bedevere-bot
Copy link

bedevere-bot commented Jul 24, 2022

GH-95188 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 24, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 24, 2022
@methane @miss-islington
pythongh-93157: Fix fileinput didn't support errors in inplace mo…
a3dbeef 
…de (pythonGH-95128)

(cherry picked from commit 5c7f3bc)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 24, 2022
@methane @miss-islington
pythongh-93157: Fix fileinput didn't support errors in inplace mo…
c4ebeea 
…de (pythonGH-95128)

(cherry picked from commit 5c7f3bc)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
miss-islington added a commit that referenced this pull request Jul 24, 2022
@miss-islington @methane
gh-93157: Fix fileinput didn't support errors in inplace mode (GH…
4a682b4 
…-95128)

(cherry picked from commit 5c7f3bc)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
miss-islington added a commit that referenced this pull request Jul 24, 2022
@miss-islington @methane
gh-93157: Fix fileinput didn't support errors in inplace mode (GH…
22f06d6 
…-95128)

(cherry picked from commit 5c7f3bc)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fileinput with inplace=True ignores errors parameter

3 participants

@methane @miss-islington @bedevere-bot