Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34762: Fix contextvars C API to use PyObject* pointer types. #9473

Merged
merged 3 commits into from
Sep 21, 2018
Merged

bpo-34762: Fix contextvars C API to use PyObject* pointer types. #9473

merged 3 commits into from
Sep 21, 2018

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Sep 21, 2018 •
edited
Loading

  • Note: if this PR is accepted I'll update the docs before merging it.

https://bugs.python.org/issue34762

vstinner
vstinner approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@1st1
Copy link
Member Author

1st1 commented Sep 21, 2018

@elprans Please take a look at the docs update (and PR in general).

@1st1
Copy link
Member Author

1st1 commented Sep 21, 2018

This is how the docs section looks when rendered:

screen shot 2018-09-21 at 2 54 11 pm

elprans
elprans approved these changes Sep 21, 2018
View reviewed changes
@1st1 1st1 merged commit 2ec872b into python:master Sep 21, 2018
@miss-islington
Copy link
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@1st1 1st1 deleted the fix567 branch September 21, 2018 19:34
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 21, 2018
@1st1 @miss-islington
bpo-34762: Fix contextvars C API to use PyObject* pointer types. (pyt…
54e4a89 
…honGH-9473)

(cherry picked from commit 2ec872b)

Co-authored-by: Yury Selivanov <yury@magic.io>
@bedevere-bot
Copy link

GH-9478 is a backport of this pull request to the 3.7 branch.

@1st1
Copy link
Member Author

1st1 commented Sep 21, 2018

Thanks everybody for reviews!

miss-islington added a commit that referenced this pull request Sep 21, 2018
@miss-islington @1st1
bpo-34762: Fix contextvars C API to use PyObject* pointer types. (GH-…
187f2dd 
…9473)

(cherry picked from commit 2ec872b)

Co-authored-by: Yury Selivanov <yury@magic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@elprans elprans elprans approved these changes

@asvetlov asvetlov asvetlov approved these changes

@rhettinger rhettinger rhettinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@1st1 @miss-islington @bedevere-bot @vstinner @elprans @asvetlov @rhettinger @the-knights-who-say-ni