bpo-34652: Remove lchmod from the big func checking block. #9247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arfrever
reviewed
Sep 12, 2018
pyconfig.h.in
Outdated
| @@ -557,9 +557,6 @@ | |||
| /* Define to 1 if you have the 'lchflags' function. */ | |||
| #undef HAVE_LCHFLAGS | |||
|
|
|||
| /* Define to 1 if you have the `lchmod' function. */ | |||
| #undef HAVE_LCHMOD | |||
There was a problem hiding this comment.
Apparently AC_CHECK_FUNCS defines HAVE_* preprocessor macro when a function is found, but AC_CHECK_FUNC does not.
So AC_CHECK_FUNC(lchmod) should be changed to AC_CHECK_FUNCS(lchmod).
Then above deletion from pyconfig.h.in should disappear.
|
Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2018
|
GH-9249 is a backport of this pull request to the 3.7 branch. |
|
Sorry, @benjaminp, I could not cleanly backport this to |
benjaminp
added a commit
that referenced
this pull request
Sep 13, 2018
miss-islington
added a commit
that referenced
this pull request
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for 883702e.
https://bugs.python.org/issue34652