Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91432: Add FOR_END, alternate: keep FOR_ITER around. #91472

Closed
wants to merge 33 commits into from
Closed

gh-91432: Add FOR_END, alternate: keep FOR_ITER around. #91472

wants to merge 33 commits into from

Conversation

sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Apr 12, 2022 •
edited
Loading

#91432

TODO: fix docs and whatsnew

sweeneyde and others added 30 commits February 20, 2022 01:17
@sweeneyde
Implement FOR_END
f7c220a
@sweeneyde
Use jabs, not jrel
4178c30
@sweeneyde
Bump magic
245b43f
@sweeneyde
merge with main
61a85f0
@sweeneyde
merge with main
b0030d5
@sweeneyde
Remove FOR_ITER entirely
8f3cd5a
@sweeneyde
Fix some failng tests
4520a5a
@sweeneyde
exclude test_frozenmain
6284f20
@sweeneyde
merge with main
3a0d53e
@sweeneyde
fix some tracing tests
3b328e7
@sweeneyde
fix swap pop/push in frameobject.c
bdd7f07
@sweeneyde
merge with main
b20fed8
@sweeneyde
Get test.test_trace passing
77d52e6
@sweeneyde
when marking backwards jumps, set todo=1
53a8734
@sweeneyde
remove debugging code
7d32011
@sweeneyde
update test_dis
4a2e781
@sweeneyde
make FOR_END a relative jump
0af7e1e
@sweeneyde
make test.test_bdb and test.test_pdb pass
d3552aa
@sweeneyde
refactor maybe_call_line_trace logic
563ca00
@sweeneyde
add blurb
719e756
@sweeneyde
FOR_ITER --> FOR_END in dis.rst
8626569
@sweeneyde
FOR_ITER --> FOR_END in specialize.c
2884727
@sweeneyde
Update whatsnew
44baacc
@sweeneyde
Merge branch 'main' into for_end
0adffbd
@sweeneyde
merge with main
7a62601
@sweeneyde
Merge branch 'for_end' of https://github.com/sweeneyde/cpython into f…
92e8c6d 
…or_end
@sweeneyde
fix test_dis
e4f240e
@sweeneyde
Merge branch 'main' into for_end
6c2e53d
@sweeneyde
fix opcode.h
32bed37
@sweeneyde
Re-introduce FOR_ITER
1a19c91
@sweeneyde sweeneyde changed the title Add FOR_END, alternate: keep FOR_ITER around. gh-91432: Add FOR_END, alternate: keep FOR_ITER around. Apr 12, 2022
@sweeneyde sweeneyde mentioned this pull request Apr 12, 2022
Closed
@sweeneyde sweeneyde closed this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon will be requested when the pull request is marked ready for review brettcannon is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan will be requested when the pull request is marked ready for review ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw will be requested when the pull request is marked ready for review warsaw is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel will be requested when the pull request is marked ready for review iritkatriel is a code owner

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sweeneyde @bedevere-bot