Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] bpo-33839: refactor IDLE's tooltips & calltips, add docstrings and tests (GH-7683) #8675

Merged
merged 1 commit into from
Aug 5, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 5, 2018

  • make CallTip and ToolTip sub-classes of a common abstract base class
  • remove ListboxToolTip (unused and ugly)
  • greatly increase test coverage
  • tested on Windows, Linux and macOS
    (cherry picked from commit 87e59ac)

Co-authored-by: Tal Einat taleinat+github@gmail.com

https://bugs.python.org/issue33839

…sts (pythonGH-7683)

* make CallTip and ToolTip sub-classes of a common abstract base class
* remove ListboxToolTip (unused and ugly)
* greatly increase test coverage
* tested on Windows, Linux and macOS
(cherry picked from commit 87e59ac)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
@miss-islington
Copy link
Contributor Author

@taleinat: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit e65ec49 into python:3.7 Aug 5, 2018
@miss-islington miss-islington deleted the backport-87e59ac-3.7 branch August 5, 2018 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants