Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make examples in Functional Programming HOWTO to be PEP-8 compliant. #8646

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Make examples in Functional Programming HOWTO to be PEP-8 compliant. #8646

merged 1 commit into from
Aug 7, 2018

Conversation

sir-sigurd
Copy link
Contributor

No description provided.

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Aug 3, 2018
Mariatta
Mariatta approved these changes Aug 7, 2018
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I would reject PEP 8 PRs to the codebase, but since this is for documentation I'm fine with it.

@Mariatta Mariatta merged commit db8707c into python:master Aug 7, 2018
@miss-islington
Copy link
Contributor

Thanks @sir-sigurd for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@Mariatta
Copy link
Member

Mariatta commented Aug 7, 2018

Thanks! 🌮

@bedevere-bot
Copy link

GH-8705 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-8706 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 7, 2018
@sir-sigurd @miss-islington
Make code examples in Functional Programming HOWTO to be PEP 8 compli…
11e058c 
…ant. (pythonGH-8646)

(cherry picked from commit db8707c)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 7, 2018
@sir-sigurd @miss-islington
Make code examples in Functional Programming HOWTO to be PEP 8 compli…
c735308 
…ant. (pythonGH-8646)

(cherry picked from commit db8707c)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
miss-islington added a commit that referenced this pull request Aug 7, 2018
@miss-islington @sir-sigurd
Make code examples in Functional Programming HOWTO to be PEP 8 compli…
2920303 
…ant. (GH-8646)

(cherry picked from commit db8707c)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
Mariatta pushed a commit that referenced this pull request Aug 7, 2018
@miss-islington @sir-sigurd @Mariatta
Make code examples in Functional Programming HOWTO to be PEP 8 compli…
f2bb20e 
…ant. (GH-8646)

(cherry picked from commit db8707c)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
@sir-sigurd sir-sigurd deleted the functools-howto branch August 8, 2018 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sir-sigurd @miss-islington @Mariatta @bedevere-bot @the-knights-who-say-ni