bpo-34061: Add missing docs for NotSupportedError sqlite module #8172
Conversation
Doc/library/sqlite3.rst
Outdated
| Exception raised in case a method or database API was used which is not | ||
| supported by the database, e.g. requesting a .rollback() on a connection | ||
| that does not support transaction or has transactions turned off. | ||
| It must be a subclass of :exc:`DatabaseError`. |
There was a problem hiding this comment.
It must be -> It is (PEP 249 is basically a specification, and it has already been implemented in the sqlite3 module, so we don't need use "must be".)
Doc/library/sqlite3.rst
Outdated
| .. exception:: NotSupportedError | ||
|
|
||
| Exception raised in case a method or database API was used which is not | ||
| supported by the database, e.g. requesting a .rollback() on a connection |
There was a problem hiding this comment.
Perhaps we can replace "requesting a .rollback() on" with something like "calling the :meth:`Connection.rollback` method on" to make it sound more like stdlib documentation, not PEP 249?
Misc/ACKS
Outdated
| @@ -1784,6 +1784,7 @@ Gordon Worley | |||
| Darren Worrall | |||
| Thomas Wouters | |||
| Daniel Wozniak | |||
| Marcin Niemira | |||
There was a problem hiding this comment.
Thank you for adding your name to the list, but I usually prefer adding a contributor's name for more complicated patches (or after a couple of trivial patches)
There was a problem hiding this comment.
Already merged by other PR.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Hi, I've fixed requested changes. Thanks for Review. |
Doc/library/sqlite3.rst
Outdated
| .. exception:: NotSupportedError | ||
|
|
||
| Exception raised in case a method or database API was used which is not | ||
| supported by the database, e.g. calling the :meth:`Connection.rollback` |
There was a problem hiding this comment.
I think :meth:`~Connection.rollback` would be a better choice here.
There was a problem hiding this comment.
added missing "method" word & changed :meth:`Connection.rollback to the :meth:`~Connection.rollback
|
Thanks @n0npax for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
Thanks! |
|
Sorry, @n0npax and @berkerpeksag, I could not cleanly backport this to |
|
Sorry, @n0npax and @berkerpeksag, I could not cleanly backport this to |
|
@n0npax would you like to submit backport PRs? |
(cherry picked from commit bc9aa81) Co-authored-by: Marcin Niemira <marcin@niemira.net>
|
GH-8185 is a backport of this pull request to the 3.6 branch. |
(cherry picked from commit bc9aa81) Co-authored-by: Marcin Niemira <marcin@niemira.net>
(cherry picked from commit bc9aa81) Co-authored-by: Marcin Niemira <marcin@niemira.net>
|
GH-8186 is a backport of this pull request to the 3.7 branch. |
|
PR prepared. |
Add missing docs for NotSupportedError in sqlite module
https://bugs.python.org/issue34061