Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-20602: Do not clear sys.flags and sys.float_info during shutdown #8096

Merged
merged 1 commit into from
May 30, 2019
Merged

bpo-20602: Do not clear sys.flags and sys.float_info during shutdown #8096

merged 1 commit into from
May 30, 2019

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Jul 4, 2018 •
edited by bedevere-bot
Loading

There is no need to clear these immutable objects during shutdown.

https://bugs.python.org/issue20602

@ZackerySpytz ZackerySpytz requested a review from a team July 4, 2018 22:59
@serhiy-storchaka serhiy-storchaka requested review from tiran and removed request for a team July 5, 2018 12:38
serhiy-storchaka
serhiy-storchaka previously requested changes Oct 12, 2018
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ZackerySpytz
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

tiran
tiran approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The PR has been dormant for a while. Do you want to land it in 3.8?

@ZackerySpytz
Copy link
Contributor Author

Thanks for the review, @tiran.

For what it's worth, I would like to see this land in 3.8.

@tiran
Copy link
Member

tiran commented May 29, 2019

@ZackerySpytz Could you please rebase the PR to kick off another test run?

@ZackerySpytz
bpo-20602: Do not clear sys.flags and sys.float_info during shutdown
932feb6 
There is no need to clear these immutable objects during shutdown.
@ZackerySpytz ZackerySpytz force-pushed the bpo-20602-sys-flags-sys-float_info-clear branch from dd4b698 to 932feb6 Compare May 29, 2019 21:20
tiran
tiran approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@encukou encukou merged commit 249b7d5 into python:master May 30, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@ZackerySpytz @DinoV
bpo-20602: Do not clear sys.flags and sys.float_info during shutdown (p…
6e0a3e7 
…ythonGH-8096)

There is no need to clear these immutable objects during shutdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@brettcannon brettcannon Awaiting requested review from brettcannon

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@warsaw warsaw Awaiting requested review from warsaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZackerySpytz @bedevere-bot @tiran @serhiy-storchaka @encukou @the-knights-who-say-ni