bpo-33924: Change IDLE mainmenu.menudefs key 'windows' to 'window' #7836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match Window on the main menu and remove last plural module name.
Every other menudef key is lowercase version of main menu entry.
# Conflicts: fixed # Lib/idlelib/editor.py
terryjreedy
added
type-bug
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 21, 2018
…ythonGH-7836) Every other menudef key is the lowercase version of the corresponding main menu entry (in this case, 'Window'). (cherry picked from commit 33c7420) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-7837 is a backport of this pull request to the 3.7 branch. |
|
GH-7838 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 21, 2018
…ythonGH-7836) Every other menudef key is the lowercase version of the corresponding main menu entry (in this case, 'Window'). (cherry picked from commit 33c7420) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
added a commit
that referenced
this pull request
Jun 21, 2018
miss-islington
added a commit
that referenced
this pull request
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every other menudef key is lowercase version of main menu entry.
https://bugs.python.org/issue33924