Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33614: Ensures module definition files for the stable ABI on Windows are correctly regenerated #7165

Merged
merged 1 commit into from
May 28, 2018
Merged

bpo-33614: Ensures module definition files for the stable ABI on Windows are correctly regenerated #7165

merged 1 commit into from
May 28, 2018

Conversation

zooba
Copy link
Member

@zooba zooba commented May 28, 2018 •
edited
Loading

Also includes a minor improvement to find_MSBuild.bat to handle the case where %MSBUILD% is set to the directory rather than the executable.

@zooba zooba requested a review from a team as a code owner May 28, 2018 18:43
@zooba zooba merged commit e97ba4c into python:master May 28, 2018
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@zooba zooba deleted the bpo-33614 branch May 28, 2018 19:32
@bedevere-bot
Copy link

GH-7167 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2018
@zooba @miss-islington
bpo-33614: Ensures module definition files for the stable ABI on Wind…
5f82aa4 
…ows are correctly regenerated. (pythonGH-7165)

(cherry picked from commit e97ba4c)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2018
@zooba @miss-islington
bpo-33614: Ensures module definition files for the stable ABI on Wind…
da02a51 
…ows are correctly regenerated. (pythonGH-7165)

(cherry picked from commit e97ba4c)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@bedevere-bot
Copy link

GH-7168 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request May 28, 2018
@miss-islington @zooba
bpo-33614: Ensures module definition files for the stable ABI on Wind…
3757939 
…ows are correctly regenerated. (GH-7165)

(cherry picked from commit e97ba4c)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
miss-islington added a commit that referenced this pull request May 28, 2018
@miss-islington @zooba
bpo-33614: Ensures module definition files for the stable ABI on Wind…
c489a76 
…ows are correctly regenerated. (GH-7165)

(cherry picked from commit e97ba4c)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OS-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zooba @miss-islington @bedevere-bot @the-knights-who-say-ni