Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33648: remove PY_WARN_ON_C_LOCALE #7114

Merged
merged 7 commits into from
Jul 11, 2018
Merged

bpo-33648: remove PY_WARN_ON_C_LOCALE #7114

merged 7 commits into from
Jul 11, 2018

Conversation

grimreaper
Copy link
Contributor

@grimreaper grimreaper commented May 25, 2018 •
edited by bedevere-bot
Loading

This code does not appear to be used anywhere in the python code base. The
use was removed in eb81795.

https://bugs.python.org/issue33648

@ncoghlan
Copy link
Contributor

This seems to have lost quite a few PKG-CONFIG related settings as well.

Tagging @benjaminp since those settings appear to come from 03c0d2e#diff-9ceb48203b3fd0a963276aeb22265658 after mostly being removed in 5401622#diff-9ceb48203b3fd0a963276aeb22265658

@methane
Copy link
Member

methane commented Jun 7, 2018

@grimreaper Would you minimize changes?

@grimreaper grimreaper force-pushed the eax/bpo-33648/unused-flag branch from 14063c6 to f60223b Compare June 9, 2018 17:46
@grimreaper
Copy link
Contributor Author

hrm... a regen results in new unexpected changes. It seems someone ran a regen with a different set o tools than I do ?

@grimreaper
Copy link
Contributor Author

Ah, I see

-[m4_define([PKG_MACROS_VERSION], [0.29.2])
+[m4_define([PKG_MACROS_VERSION], [0.29.1])

I'll try and fix this

@grimreaper grimreaper force-pushed the eax/bpo-33648/unused-flag branch from f60223b to 0a5cc26 Compare June 29, 2018 07:24
@grimreaper
bpo-33648: remove PY_WARN_ON_C_LOCALE
c96dc1d 
This code does not appear to be used anywhere in the python code base.
The use was removed in eb81795.
@grimreaper
regen
5a7e059
@grimreaper
Add news
54dd62d
@grimreaper
regen v2
92d56fa
@grimreaper
regen
dec82f3
@grimreaper
Add myself
2c7bccd
@grimreaper grimreaper force-pushed the eax/bpo-33648/unused-flag branch from 0a5cc26 to 2c7bccd Compare June 29, 2018 14:32
@methane methane merged commit b91a3a0 into python:master Jul 11, 2018
@miss-islington
Copy link
Contributor

Thanks @grimreaper for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 11, 2018
@grimreaper @miss-islington
bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
59320d5 
This code does not appear to be used anywhere in the python code base.
The use was removed in eb81795.
(cherry picked from commit b91a3a0)

Co-authored-by: Eitan Adler <grimreaper@users.noreply.github.com>
@bedevere-bot
Copy link

GH-8250 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jul 11, 2018
@miss-islington @grimreaper
bpo-33648: Remove PY_WARN_ON_C_LOCALE (GH-7114)
020f5ab 
This code does not appear to be used anywhere in the python code base.
The use was removed in eb81795.
(cherry picked from commit b91a3a0)

Co-authored-by: Eitan Adler <grimreaper@users.noreply.github.com>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Jul 14, 2018
@CuriousLearner
Merge branch 'master' into bitwise_docs
11c1706 
* master: (2633 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Jul 15, 2018
@CuriousLearner
Merge branch 'master' into fix-issue8525
fdc3a3d 
* master: (1159 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Jul 21, 2018
@CuriousLearner
Merge branch 'master' of github.com:CuriousLearner/cpython into fix-i…
7b039a0 
…ssue-33014

* 'master' of github.com:CuriousLearner/cpython: (722 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@grimreaper @ncoghlan @methane @miss-islington @bedevere-bot @the-knights-who-say-ni