[skip issue]Small changes in importing process of multiprocessing package by bombs-kim · Pull Request #6856 · python/cpython

bombs-kim · 2018-05-15T10:08:34Z

It seems that the way multiprocessing package set __all__ is overly complex. And __all__ in context.py is not used in __init__.py so I guess the comment there is misleading.

…in __init__.py

bombs-kim · 2018-05-23T05:00:45Z

@1st1 I've submitted PSF form. Maybe some errors has happened. Could you please check this out and remove CLA not sign tag?

1st1 · 2018-05-23T05:06:40Z

Added Davin as a reviewer as multiprocessing is his territory.

serhiy-storchaka · 2018-05-23T05:34:40Z

Please add tests for __all__. The test.support.check__all__ helper can be used for this.

bombs-kim · 2018-05-24T00:01:07Z

@serhiy-storchaka Thank you so much. I will upload that as early as I can, but it can take some time because I'm new to test

serhiy-storchaka · 2018-05-24T04:56:47Z

Just look how this helper is used in other tests.

bombs-kim · 2018-06-01T02:09:01Z

@serhiy-storchaka Sorry for being late. I've added a test case but I'm not sure this is what you intended. Public objects in multiprocessing package are bound methods of multiprocessing.context._default_context object and they don't have __module__ attributes and they are not types.ModuleType, either. So I think using check__all__ is pretty pointless here because you cannot make expected automatically in that function.

bombs-kim · 2018-06-15T04:09:45Z

@applio I know it's a trivial contribution, but I want to know the progress of PR.

methane · 2018-06-28T09:09:01Z

Lib/multiprocessing/__init__.py

-globals().update((name, getattr(context._default_context, name))
-                 for name in context._default_context.__all__)
-__all__ = context._default_context.__all__
+__all__ = [x for x in dir(context._default_context) if not x[0].startswith('_')]


Shouldn't x[0].startswith('_') be x.startswith('_')?

Yes, you are right. Thank you🙂

methane · 2018-06-28T09:10:36Z

Lib/multiprocessing/context.py

 from . import reduction

-__all__ = []            # things are copied from here to __init__.py
+__all__ = []


Could we use __all__ = ()? Or __all__ is modified later?

I don't think it's modified. I will run the test and tell you the result

@methane I updated things that you pointed out. It passed all tests. Thanks.

* master: (2633 commits) bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274) bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271) bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924) bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267) bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261) bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222) Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887) bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192) bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114) bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245) Simplify __all__ in multiprocessing (pythonGH-6856) bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230) Doc: Point to Simple statements section instead of PEP (pythonGH-8238) bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139) bpo-33597: Add What's New for PyGC_Head (pythonGH-8236) Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038) Fix documentation for input and output tutorial (pythonGH-8231) bpo-34009: Expand on platform support changes (pythonGH-8022) Factor-out two substantially identical code blocks. (pythonGH-8219) bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091) ...

* master: (1159 commits) bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274) bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271) bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924) bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267) bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261) bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222) Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887) bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192) bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114) bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245) Simplify __all__ in multiprocessing (pythonGH-6856) bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230) Doc: Point to Simple statements section instead of PEP (pythonGH-8238) bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139) bpo-33597: Add What's New for PyGC_Head (pythonGH-8236) Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038) Fix documentation for input and output tutorial (pythonGH-8231) bpo-34009: Expand on platform support changes (pythonGH-8022) Factor-out two substantially identical code blocks. (pythonGH-8219) bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091) ...

…ssue-33014 * 'master' of github.com:CuriousLearner/cpython: (722 commits) bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274) bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271) bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924) bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267) bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261) bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222) Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887) bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192) bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114) bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245) Simplify __all__ in multiprocessing (pythonGH-6856) bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230) Doc: Point to Simple statements section instead of PEP (pythonGH-8238) bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139) bpo-33597: Add What's New for PyGC_Head (pythonGH-8236) Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038) Fix documentation for input and output tutorial (pythonGH-8231) bpo-34009: Expand on platform support changes (pythonGH-8022) Factor-out two substantially identical code blocks. (pythonGH-8219) bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091) ...

Derek Kim added 2 commits May 15, 2018 18:55

Changed unnecessarily complex way of updating of __all__ and globals …

02c298d

…in __init__.py

Maybe a misguiding comment

eb07cb5

bombs-kim requested a review from 1st1 as a code owner May 15, 2018 10:08

This comment has been minimized.

Sign in to view

the-knights-who-say-ni added the CLA not signed label May 15, 2018

bedevere-bot added the awaiting review label May 15, 2018

bombs-kim changed the title ~~Small changes in importing mechanism of multiprocessing library~~ Small changes in importing process of multiprocessing package May 15, 2018

This comment has been minimized.

Sign in to view

1st1 removed the CLA not signed label May 23, 2018

the-knights-who-say-ni added the CLA signed label May 23, 2018

1st1 requested review from applio and removed request for 1st1 May 23, 2018 05:06

Added a trivial test for __all__

25335c3

bombs-kim changed the title ~~Small changes in importing process of multiprocessing package~~ [skip issue]Small changes in importing process of multiprocessing package Jun 15, 2018

methane reviewed Jun 28, 2018

View reviewed changes

Derek Kim added 2 commits July 3, 2018 17:43

Trivial error fixed

ef222ac

__all__ is not supposed to be modified

2e617a2

methane added skip issue skip news labels Jul 11, 2018

methane merged commit c40278e into python:master Jul 11, 2018

bedevere-bot removed the awaiting review label Jul 11, 2018

Uh oh!

Conversation

bombs-kim commented May 15, 2018 • edited by methane Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

bombs-kim commented May 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

1st1 commented May 23, 2018

Uh oh!

serhiy-storchaka commented May 23, 2018

Uh oh!

bombs-kim commented May 24, 2018

Uh oh!

serhiy-storchaka commented May 24, 2018

Uh oh!

bombs-kim commented Jun 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bombs-kim commented Jun 15, 2018

Uh oh!

methane Jun 28, 2018

Choose a reason for hiding this comment

Uh oh!

bombs-kim Jun 28, 2018

Choose a reason for hiding this comment

Uh oh!

methane Jun 28, 2018

Choose a reason for hiding this comment

Uh oh!

bombs-kim Jun 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bombs-kim Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bombs-kim commented May 15, 2018 •

edited by methane

Loading

bombs-kim commented May 23, 2018 •

edited

Loading

bombs-kim commented Jun 1, 2018 •

edited

Loading

bombs-kim Jun 28, 2018 •

edited

Loading

bombs-kim Jul 3, 2018 •

edited

Loading