Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33131: Upgrade ensurepip to pip 10.0.1 #6546

Merged
merged 2 commits into from
Apr 20, 2018
Merged

bpo-33131: Upgrade ensurepip to pip 10.0.1 #6546

merged 2 commits into from
Apr 20, 2018

Conversation

pfmoore
Copy link
Member

@pfmoore pfmoore commented Apr 20, 2018 •
edited by bedevere-bot
Loading

Pip 10 has been released - this upgrades the version in ensurepip to 10.0.1

https://bugs.python.org/issue33131

@pfmoore pfmoore requested a review from dstufft April 20, 2018 15:03
@dstufft
Copy link
Member

dstufft commented Apr 20, 2018

We should also backport this to all the relevant versions that are still accepting backports.

@pfmoore
Copy link
Member Author

pfmoore commented Apr 20, 2018

Agreed - thanks for the reminder. I had that on my list to do just before merge (it's just adding labels and letting the bot do its thing, I believe)

@ncoghlan
Copy link
Contributor

Given the pip level API compatibility break, I think the main branches it would make sense to backport to are 2.7 and 3.7.

For 3.6.x, even though it's nominally still open to general bug fixes, I figure it makes sense to let folks decide for themselves if they want to stick with 9.0.x for now.

@ncoghlan
Copy link
Contributor

The test failure is genuine - ensurepip currently relies on pip.main to let it run pip directly from the wheel archive without unpacking it to a temporary directory first.

@pfmoore
Copy link
Member Author

pfmoore commented Apr 20, 2018

@ncoghlan Yeah my bad. I saw it earlier, it's an easy fix just getting to it now.

@pfmoore pfmoore merged commit 0399cf9 into python:master Apr 20, 2018
@miss-islington
Copy link
Contributor

Thanks @pfmoore for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7.
🐍🍒⛏🤖

@pfmoore pfmoore deleted the pip-10.0.1 branch April 20, 2018 20:06
@bedevere-bot
Copy link

GH-6550 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 20, 2018
@pfmoore @miss-islington
bpo-33131: Upgrade ensurepip to bundle pip 10.0.1 (pythonGH-6546)
e865fcb 
Upgrade ensurepip to bundle pip 10.0.1
(cherry picked from commit 0399cf9)

Co-authored-by: Paul Moore <p.f.moore@gmail.com>
@bedevere-bot
Copy link

GH-6551 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 20, 2018
@pfmoore @miss-islington
bpo-33131: Upgrade ensurepip to bundle pip 10.0.1 (pythonGH-6546)
4a20239 
Upgrade ensurepip to bundle pip 10.0.1
(cherry picked from commit 0399cf9)

Co-authored-by: Paul Moore <p.f.moore@gmail.com>
@ned-deily
Copy link
Member

If we're upgrading 2.7, we should upgrade 3.6, too. Otherwise, 3.6 users are going to be harangued by pip upgrade messages.

@pfmoore
Copy link
Member Author

pfmoore commented Apr 20, 2018

Um. OK. I don't have an opinion myself, so I'm happy to go with that - but given that I've hit merge and the bots are doing their thing, what do I need to do now to upgrade 3.6?

@ned-deily
Copy link
Member

You just need to add the "needs backport to 3.6" label.

@pfmoore
Copy link
Member Author

pfmoore commented Apr 20, 2018

Cool! I thought I had to do that before I merged. Yet again, I'm impressed by how easy the new workflow is :-)

@miss-islington
Copy link
Contributor

Thanks @pfmoore for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@ned-deily
Copy link
Member

Clever bots!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 20, 2018
@pfmoore @miss-islington
bpo-33131: Upgrade ensurepip to bundle pip 10.0.1 (pythonGH-6546)
1f911a6 
Upgrade ensurepip to bundle pip 10.0.1
(cherry picked from commit 0399cf9)

Co-authored-by: Paul Moore <p.f.moore@gmail.com>
@bedevere-bot
Copy link

GH-6553 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Apr 20, 2018
@miss-islington @pfmoore
bpo-33131: Upgrade ensurepip to bundle pip 10.0.1 (GH-6546)
b221107 
Upgrade ensurepip to bundle pip 10.0.1
(cherry picked from commit 0399cf9)

Co-authored-by: Paul Moore <p.f.moore@gmail.com>
miss-islington added a commit that referenced this pull request Apr 20, 2018
@miss-islington @pfmoore
bpo-33131: Upgrade ensurepip to bundle pip 10.0.1 (GH-6546)
4caba7a 
Upgrade ensurepip to bundle pip 10.0.1
(cherry picked from commit 0399cf9)

Co-authored-by: Paul Moore <p.f.moore@gmail.com>
miss-islington added a commit that referenced this pull request Apr 20, 2018
@miss-islington @pfmoore
bpo-33131: Upgrade ensurepip to bundle pip 10.0.1 (GH-6546)
47d57bf 
Upgrade ensurepip to bundle pip 10.0.1
(cherry picked from commit 0399cf9)

Co-authored-by: Paul Moore <p.f.moore@gmail.com>
@ncoghlan
Copy link
Contributor

The bots can even cope if you miss that they already created the backport PR and mistakenly re-add the backport label. They're pretty cool :)

@pfmoore
Copy link
Member Author

pfmoore commented Apr 21, 2018

The bots are incredibly impressive. Genuinely feels like magic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstufft dstufft dstufft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pfmoore @dstufft @ncoghlan @miss-islington @bedevere-bot @ned-deily @the-knights-who-say-ni