Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] bpo-33096: Fix ttk.Treeview.insert. (GH-6228) #6326

Merged
merged 1 commit into from
Mar 31, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 31, 2018

Allow ttk.Treeview.insert to insert iid that has a false boolean value.
Note iid=0 and iid=False would be same..
(cherry picked from commit 3ab44c0)

Co-authored-by: Garvit Khatri garvitdelhi@gmail.com

https://bugs.python.org/issue33096

Allow ttk.Treeview.insert to insert iid that has a false boolean value.
Note iid=0 and iid=False would be same..
(cherry picked from commit 3ab44c0)

Co-authored-by: Garvit Khatri <garvitdelhi@gmail.com>
@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Mar 31, 2018
@serhiy-storchaka serhiy-storchaka merged commit e80a232 into python:2.7 Mar 31, 2018
@serhiy-storchaka serhiy-storchaka deleted the backport-3ab44c0-2.7 branch March 31, 2018 23:43
@jakirkham
Copy link

So we ran into an issue compiling ttk.py with Python 2.7 as part of the Python 2.7 build process on Windows. Appears it has some Python 3 syntax in at least one place. Have not looked through the rest of ttk.py or any of the other files, but figured I'd mention it here. Traceback and link to log from the build included below.

C:\bld\python_1525666272216\work\Lib\xml\sax\__init__.py
1994 File(s) copied
        1 file(s) moved.
        1 dir(s) moved.
        1 file(s) moved.
        1 dir(s) moved.
Compiling C:\bld\python_1525666272216\_h_env\Lib\tkinter\ttk.py ...
  File "C:\bld\python_1525666272216\_h_env\Lib\tkinter\ttk.py", line 83
    for *state, val in items:
        ^
SyntaxError: invalid syntax

ref: https://ci.appveyor.com/project/conda-forge/python-feedstock/build/1.0.334

@serhiy-storchaka
Copy link
Member Author

Thank you for your report @jakirkham! Some files unintentionally were copied from Python 3. Will be fixed by #6724.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants