Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33138: Change standard error message for non-pickleable and non-copyable types. #6239

Merged
merged 6 commits into from
Oct 31, 2018
Merged

bpo-33138: Change standard error message for non-pickleable and non-copyable types. #6239

merged 6 commits into from
Oct 31, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 25, 2018 •
edited by bedevere-bot
Loading

It now says "cannot serialize" instead of "can't pickle".

https://bugs.python.org/issue33138

@serhiy-storchaka
bpo-33138: Chang standard error message for non-pickleable and non-co…
b00c067 
…pyable types.

It now says "cannot serialize" instead of "can't pickle".
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Mar 25, 2018
@serhiy-storchaka serhiy-storchaka changed the title bpo-33138: Chang standard error message for non-pickleable and non-copyable types. bpo-33138: Change standard error message for non-pickleable and non-copyable types. Jun 8, 2018
@serhiy-storchaka serhiy-storchaka requested a review from tiran July 8, 2018 07:08
@serhiy-storchaka
Copy link
Member Author

I'm going to merge this PR if there are no other suggestions.

ZackerySpytz
ZackerySpytz reviewed Jul 25, 2018
View reviewed changes
vstinner
vstinner approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 0353b4e into python:master Oct 31, 2018
@serhiy-storchaka serhiy-storchaka deleted the non-serializable-error branch October 31, 2018 00:28
@harupy harupy mentioned this pull request Mar 4, 2022
Merged
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackerySpytz ZackerySpytz ZackerySpytz left review comments

@vstinner vstinner vstinner approved these changes

@methane methane methane approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@serhiy-storchaka @vstinner @methane @ZackerySpytz @the-knights-who-say-ni @bedevere-bot