Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32505: dataclasses: raise TypeError if a member variable is of type Field, but doesn't have a type annotation. #6192

Merged
merged 3 commits into from
Mar 22, 2018
Merged

bpo-32505: dataclasses: raise TypeError if a member variable is of type Field, but doesn't have a type annotation. #6192

merged 3 commits into from
Mar 22, 2018

Conversation

ericvsmith
Copy link
Member

@ericvsmith ericvsmith commented Mar 22, 2018 •
edited by bedevere-bot
Loading

@ericvsmith ericvsmith self-assigned this Mar 22, 2018
ilevkivskyi
ilevkivskyi approved these changes Mar 22, 2018
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@ericvsmith ericvsmith merged commit 56970b8 into python:master Mar 22, 2018
@miss-islington
Copy link
Contributor

Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-6193 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 22, 2018
@ericvsmith @miss-islington
bpo-32505: dataclasses: raise TypeError if a member variable is of ty…
fd48236 
…pe Field, but doesn't have a type annotation. (pythonGH-6192)

If a dataclass has a member variable that's of type Field, but it doesn't have a type annotation, raise TypeError.
(cherry picked from commit 56970b8)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@ericvsmith ericvsmith deleted the bpo-32505-field-with-no-type-annotation branch March 22, 2018 20:30
miss-islington added a commit that referenced this pull request Mar 22, 2018
@miss-islington @ericvsmith
bpo-32505: dataclasses: raise TypeError if a member variable is of ty…
3b4c6b1 
…pe Field, but doesn't have a type annotation. (GH-6192)

If a dataclass has a member variable that's of type Field, but it doesn't have a type annotation, raise TypeError.
(cherry picked from commit 56970b8)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
@ericvsmith @jo2y
bpo-32505: dataclasses: raise TypeError if a member variable is of ty…
2089d12 
…pe Field, but doesn't have a type annotation. (pythonGH-6192)

If a dataclass has a member variable that's of type Field, but it doesn't have a type annotation, raise TypeError.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees

@ericvsmith ericvsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ericvsmith @miss-islington @bedevere-bot @ilevkivskyi @the-knights-who-say-ni