Fix some ipaddress documentation errors #6021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zhangyangyu
commented
Mar 8, 2018
•
zhangyangyu
commented
- fix a typo
- fix the type of IPv?Network.hostmask
- add documentation about IPv?Network.netmask
- fix IPv6Network constructor doc that extended netmasks are not supported
fix a typo fix the type of IPv?Network.hostmask add documentation about IPv?Network.netmask fix IPv6Network constructor doc that extended netmasks are not supported
Mariatta
approved these changes
Mar 8, 2018
|
Thanks @zhangyangyu for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 8, 2018
* fix a typo: documention -> documentation * fix the type of IPv?Network.hostmask * add documentation about IPv?Network.netmask * fix IPv6Network constructor doc that extended netmasks are not supported (cherry picked from commit e405096) Co-authored-by: Xiang Zhang <angwerzx@126.com>
|
GH-6023 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 8, 2018
* fix a typo: documention -> documentation * fix the type of IPv?Network.hostmask * add documentation about IPv?Network.netmask * fix IPv6Network constructor doc that extended netmasks are not supported (cherry picked from commit e405096) Co-authored-by: Xiang Zhang <angwerzx@126.com>
|
GH-6024 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Mar 8, 2018
* fix a typo: documention -> documentation * fix the type of IPv?Network.hostmask * add documentation about IPv?Network.netmask * fix IPv6Network constructor doc that extended netmasks are not supported (cherry picked from commit e405096) Co-authored-by: Xiang Zhang <angwerzx@126.com>
miss-islington
added a commit
that referenced
this pull request
Mar 8, 2018
* fix a typo: documention -> documentation * fix the type of IPv?Network.hostmask * add documentation about IPv?Network.netmask * fix IPv6Network constructor doc that extended netmasks are not supported (cherry picked from commit e405096) Co-authored-by: Xiang Zhang <angwerzx@126.com>
jo2y
pushed a commit
to jo2y/cpython
that referenced
this pull request
Mar 23, 2018
* fix a typo: documention -> documentation * fix the type of IPv?Network.hostmask * add documentation about IPv?Network.netmask * fix IPv6Network constructor doc that extended netmasks are not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.