bpo-32943: Fix confusing error message for rot13 codec #5869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lib/encodings/rot_13.py
Outdated
| ### Codec APIs | ||
|
|
||
| class Codec(codecs.Codec): | ||
| def encode(self, input, errors='strict'): | ||
| _check_str(input) | ||
| return (input.translate(rot13_map), len(input)) |
There was a problem hiding this comment.
What if just use str.translate(input, rot13_map)?
There was a problem hiding this comment.
I love this approach. It avoids making the code ugly.
This reverts commit 728f772.
serhiy-storchaka
approved these changes
Mar 24, 2018
|
I think it can be backported to 3.7. @ned-deily |
|
Thanks @zhangyangyu for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-6227 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 25, 2018
(cherry picked from commit e4ce9fa) Co-authored-by: Xiang Zhang <angwerzx@126.com>
miss-islington
added a commit
that referenced
this pull request
Mar 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32943