bpo-31355: Travis-CI: re-enable macOS job #5858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
force-pushed
the
travis-ci-reenable-macos
branch
from
8acc9e9 to
6e2122b
Compare
The long build queues that plagued macOS builds on Travis seem to be a thing of the past now.
pitrou
force-pushed
the
travis-ci-reenable-macos
branch
from
7ed0c58 to
fa7bf9e
Compare
pitrou
commented
Feb 24, 2018
|
|
||
| allowed_prefixes = ('Py', '_Py') | ||
| if sys.platform == 'darwin': | ||
| allowed_prefixes += ('__Py',) |
There was a problem hiding this comment.
Apparently macOS adds an underscore before all public symbols? At least with nm...
brettcannon
approved these changes
Feb 25, 2018
|
@ned-deily are you ok with this PR? |
|
@pitrou, Sorry for not replying sooner. I'm in the middle of release stuff and was going to look further at it afterwards, also not enable it for 3.7 until the last-minute merge pushes happened. That's over now so, sure, go ahead. |
ned-deily
approved these changes
Feb 27, 2018
|
@pitrou: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long build queues that plagued macOS builds on Travis seem to be a thing of the past now.
https://bugs.python.org/issue31355