-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Pull_request_template.md file #5841
Conversation
The other option is to include a checklist that people can check off to make sure they have everything covered. Not sure if that's better than the comment since people will still need to change the body for the final commit, but it might help lead to people forgetting stuff less. |
Just go to the point.
.github/PULL_REQUEST_TEMPLATE.md
Outdated
<!-- | ||
Thanks for your contribution! | ||
|
||
Please take a quick look at those things down there. They're quite important. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Please read this comment in its entirety. It's quite important."
Thanks for the quick review! |
I don't think there's a point to making checklist if people can't physically check stuff off, so don't worry about it. |
Ok. Let's try out this new PR template for now, we can think about the checklist later. |
Changed the template to be inside an
<!-- -->
tag.Let contributors know that the PR title should include bpo number.