Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32923: Unittest doc: replace whilst with while #5833

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

Mariatta
Copy link
Member

@Mariatta Mariatta commented Feb 23, 2018

whilst and while are both english words, whilst is not as commonly used.
This can be confusing to readers whose primary language is not english.

https://bugs.python.org/issue32923

`whilst` and `while` are both english words, `whilst` is not as commonly used.
This can be confusing to readers whose primary language is not english.
@miss-islington
Copy link
Contributor

Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@Mariatta Mariatta deleted the Mariatta-bpo-32923 branch February 23, 2018 17:51
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 23, 2018
`whilst` and `while` are both english words, `whilst` is not as commonly used.
This can be confusing to readers whose primary language is not english.
(cherry picked from commit 98f42aa)

Co-authored-by: Mariatta <Mariatta@users.noreply.github.com>
@bedevere-bot
Copy link

GH-5836 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 23, 2018
`whilst` and `while` are both english words, `whilst` is not as commonly used.
This can be confusing to readers whose primary language is not english.
(cherry picked from commit 98f42aa)

Co-authored-by: Mariatta <Mariatta@users.noreply.github.com>
@bedevere-bot
Copy link

GH-5837 is a backport of this pull request to the 2.7 branch.

@bedevere-bot
Copy link

GH-5838 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 23, 2018
`whilst` and `while` are both english words, `whilst` is not as commonly used.
This can be confusing to readers whose primary language is not english.
(cherry picked from commit 98f42aa)

Co-authored-by: Mariatta <Mariatta@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Feb 23, 2018
`whilst` and `while` are both english words, `whilst` is not as commonly used.
This can be confusing to readers whose primary language is not english.
(cherry picked from commit 98f42aa)

Co-authored-by: Mariatta <Mariatta@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Feb 23, 2018
`whilst` and `while` are both english words, `whilst` is not as commonly used.
This can be confusing to readers whose primary language is not english.
(cherry picked from commit 98f42aa)

Co-authored-by: Mariatta <Mariatta@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Feb 23, 2018
`whilst` and `while` are both english words, `whilst` is not as commonly used.
This can be confusing to readers whose primary language is not english.
(cherry picked from commit 98f42aa)

Co-authored-by: Mariatta <Mariatta@users.noreply.github.com>
benjaminp pushed a commit that referenced this pull request Sep 10, 2019
As described in Doc/c-api/init.rst, PyEval_InitThreads() cannot be called
before Py_Initialize() function.
(cherry picked from commit 9e61066)

Co-authored-by: Kenta Murata <mrkn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants