bpo-32008: don't use PROTOCOL_TLSv1 in example #5789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's bad form to pin to an old version of TLS. ssl.SSLContext has the right protocol default, so let's not pass anyway.
benjaminp
force-pushed
the
benjamin-tls-1
branch
from
2e13c7c to
aee8b78
Compare
|
Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 21, 2018
It's bad form to pin to an old version of TLS. ssl.SSLContext has the right protocol default, so let's not pass anyway. (cherry picked from commit e9edee0) Co-authored-by: Benjamin Peterson <benjamin@python.org>
|
GH-5790 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 21, 2018
It's bad form to pin to an old version of TLS. ssl.SSLContext has the right protocol default, so let's not pass anyway. (cherry picked from commit e9edee0) Co-authored-by: Benjamin Peterson <benjamin@python.org>
|
GH-5791 is a backport of this pull request to the 3.6 branch. |
|
Sorry, @benjaminp, I could not cleanly backport this to |
benjaminp
added a commit
that referenced
this pull request
Feb 21, 2018
|
GH-5792 is a backport of this pull request to the 2.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 21, 2018
miss-islington
added a commit
that referenced
this pull request
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's bad form to pin to an old version of TLS.
https://bugs.python.org/issue32008