bpo-27846: Fix an incorrect note in the base64 documentation #5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This note incorrectly stated that "Base64 has an expansion factor of 6 to 4" (it is actually 4 to 3). It was decided to remove the note.
berkerpeksag
approved these changes
Feb 14, 2018
|
Thanks @ZackerySpytz for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
Thanks! |
|
GH-5668 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 14, 2018
This note incorrectly stated that "Base64 has an expansion factor of 6 to 4" (it is actually 4 to 3). It was decided to remove the note. (cherry picked from commit 88c38a4) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 14, 2018
This note incorrectly stated that "Base64 has an expansion factor of 6 to 4" (it is actually 4 to 3). It was decided to remove the note. (cherry picked from commit 88c38a4) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
GH-5669 is a backport of this pull request to the 3.6 branch. |
berkerpeksag
pushed a commit
that referenced
this pull request
Feb 14, 2018
berkerpeksag
pushed a commit
that referenced
this pull request
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This note incorrectly stated that "Base64 has an expansion factor of 6
to 4" (it is actually 4 to 3). It was decided to remove the note.
https://bugs.python.org/issue27846