Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use current name for macOS #55

Merged
merged 2 commits into from
Feb 20, 2017
Merged

Use current name for macOS #55

merged 2 commits into from
Feb 20, 2017

Conversation

paulschreiber
Copy link

No description provided.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

  1. If you don't have an account on b.p.o, please create one
  2. Make sure your GitHub username is listed in "Your Details" at b.p.o
  3. If you have not already done so, please sign the PSF contributor agreement
  4. If you just signed the CLA, please wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@vstinner
Copy link
Member

@paulschreiber: please sign the CLA.

@codecov
Copy link

codecov bot commented Feb 12, 2017

Codecov Report

Merging #55 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   82.37%   82.37%   -0.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350948              
==========================================
- Hits       289097   289095       -2     
- Misses      61851    61853       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a97d8...53d64b9. Read the comment docs.

@paulschreiber
Copy link
Author

I'm paulschreiber on bugs.python.org. I signed the CLA.

@willingc
Copy link
Contributor

@paulschreiber If you haven't put your GitHub user name in your bugs.python.org account, you will need to do that. If you have, then you should be good 👍

@brettcannon
Copy link
Member

It also takes one US business day for the CLA to get updated by a human being, so hopefully this will get cleared up sometime today or tomorrow (and I checked that the GitHub username is filled in properly on bpo).

@methane
Copy link
Member

methane commented Feb 20, 2017

@paulschreiber would you resolve conflict?

@methane methane merged commit c086685 into python:master Feb 20, 2017
@methane
Copy link
Member

methane commented Feb 20, 2017

thanks

@Mariatta
Copy link
Member

I think this needs to be backported to 3.6, 3.5, and 2.7.
I'm now getting conflict while cherry-picking my commit from GH-283.
Is it ok if I cherrypick this into 3.6, 3.5, and 2.7?
Thanks.

@ned-deily
Copy link
Member

Go ahead, I think it's OK to cherry-pick to those releases, certainly for 3.6.

Mariatta referenced this pull request in Mariatta/cpython Feb 25, 2017
@paulschreiber @Mariatta
README: OS X -> macOS (GH-55)
bb25e34 
(cherry picked from commit c086685)
@Mariatta Mariatta mentioned this pull request Feb 25, 2017
Merged
@miss-islington
Copy link
Contributor

Thanks @paulschreiber for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @paulschreiber and @methane, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.

@paulschreiber paulschreiber deleted the patch-1 branch March 26, 2019 19:14
@gvanrossum gvanrossum mentioned this pull request Apr 10, 2022
Closed
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @Mariatta
Update aiohttp from 2.3.10 to 3.0.1 (GH-55)
bc512e3
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@warsaw
Fix a setup.cfg metadata bug
bf53e07 
Closes python#55
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@warsaw
Merge branch 'issue55' into 'master'
6f9671a 
Fix a setup.cfg metadata bug

Closes python#55

See merge request python-devs/importlib_resources!59
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@webknjaz
Inject check job into CI workflow as ultimate flag (python#55)
1a6b828 
This patch adds a job that is able to accurately signal whether
all the expectations of the required jobs to succeed are met.

This job can then be used as a source of truth for judging whether
"CI passes" and can be used in the branch protection. It also plays
a role of a convenient "gate" — this is the only job that would have
to be listed in the branch protection as opposed to listing every
single job name generated by the test matrix (and they all have
different names — it's not possible to just select one `test` job
name).

Ref: https://github.com/re-actors/alls-green#why
isidentical pushed a commit to isidentical/cpython that referenced this pull request Mar 26, 2023
@pablogsal
Merge pull request python#55 from lysnikolaou/fstring-cleanup-grammar…
7b9b973 
…-actions

Cleanup grammar and actions // Remove unnecessary fstring code
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
Closed
@LinanV LinanV mentioned this pull request Oct 23, 2023
Closed
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily approved these changes

@ronaldoussoren ronaldoussoren Awaiting requested review from ronaldoussoren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@paulschreiber @the-knights-who-say-ni @vstinner @willingc @brettcannon @methane @Mariatta @ned-deily @miss-islington @zware