Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32687: Fix wrong meaning of args for PyTrace_LINE/CALL in documentation #5361

Merged
merged 2 commits into from
Jan 28, 2018

Conversation

zhangyangyu
Copy link
Member

@zhangyangyu zhangyangyu commented Jan 27, 2018

@zhangyangyu zhangyangyu added needs backport to 3.6 docs Documentation in the Doc dir labels Jan 27, 2018
@zhangyangyu zhangyangyu changed the title bpo-32687: Fix wrong meaning of args for PyTrace_LINE/CALL bpo-32687: Fix wrong meaning of args for PyTrace_LINE/CALL in documentation Jan 27, 2018
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but no need to add a NEWS entry for trivial documentation changes.

@zhangyangyu
Copy link
Member Author

Thanks @berkerpeksag , I removed the NEWS entry.

@zhangyangyu zhangyangyu merged commit 9ed0aee into python:master Jan 28, 2018
@bedevere-bot
Copy link

@zhangyangyu: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @zhangyangyu for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

@zhangyangyu zhangyangyu deleted the issue32687 branch January 28, 2018 07:38
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 28, 2018
@bedevere-bot
Copy link

GH-5377 is a backport of this pull request to the 3.6 branch.

@bedevere-bot
Copy link

GH-5378 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 28, 2018
zhangyangyu pushed a commit that referenced this pull request Jan 28, 2018
zhangyangyu pushed a commit that referenced this pull request Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants