bpo-32550. Remove the STORE_ANNOTATION bytecode. #5181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
force-pushed
the
remove-add-annotation-bytecode
branch
from
ac59ba2 to
662cc07
Compare
ilevkivskyi
previously requested changes
Jan 14, 2018
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
rhettinger
dismissed
ilevkivskyi’s stale review
Guido has opined that these little difference don't matter: https://bugs.python.org/issue32550#msg310354
markshannon
force-pushed
the
remove-add-annotation-bytecode
branch
from
7d5e204 to
5cd13af
Compare
1st1
approved these changes
Jan 29, 2018
rhettinger
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
STORE_ANNOTATIONbytecode can be implemented usingSTORE_SUBSCR.This PR does just that.
Removes over 50 lines from the interpreter, adds 4 lines to the compiler.
https://bugs.python.org/issue32550