bpo-32429: Abort compilation on outdated Modules/Setup file. #5015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienPalard
force-pushed
the
modules_setup_warning
branch
from
7f99c48
to
8c9d71c
Compare
pitrou
approved these changes
Dec 29, 2017
xdegaye
approved these changes
Dec 29, 2017
| @@ -692,7 +692,10 @@ Modules/Setup: $(srcdir)/Modules/Setup.dist | |||
| echo "check to make sure you have all the updates you"; \ | |||
| echo "need in your Modules/Setup file."; \ | |||
| echo "Usually, copying Modules/Setup.dist to Modules/Setup will work."; \ | |||
| echo "Or if you want to keep your modifications, touch Modules/Setup"; \ | |||
There was a problem hiding this comment.
When Modules/Setup.dist has been changed as for example by 7d895ac in September 2016, touching Modules/Setup is not sufficient. I suggest to remove that line.
|
That's right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32429