bpo-32262: Fix codestyle; use f-strings formatting where necessary. #4775
Conversation
Lib/asyncio/windows_utils.py
Outdated
| else: | ||
| handle = 'closed' | ||
| return '<%s %s>' % (self.__class__.__name__, handle) | ||
| return '<{} {}>'.format(self.__class__.__name__, handle) |
There was a problem hiding this comment.
Was an oversight, fixed it.
| if flags: | ||
| msg.append('flags=%r' % flags) | ||
| msg.append(f'flags={flags!r}') | ||
| msg = ', '.join(msg) | ||
| logger.debug('Get address info %s', msg) |
There was a problem hiding this comment.
No, that's logging :(
logger.debug('Get address info %s', msg) -- means that msg will be interpolated only if the logging is ON and the logging level is DEBUG. Otherwise, msg.__str__() won't be called. This is a performance thing, as __repr__() and __str__() can be expensive for some objects.
logger.debug(f'Get address info {msg}') would mean that msg.__str__() is always called, even when logging is disabled.
There was a problem hiding this comment.
In this particular case we already computed the msg, so we can inline it. In 99.9% other cases we don't want to convert logging strings.
There was a problem hiding this comment.
The problem is not only in performance.
Tools like sentry groups similar log messages basing on the message text. Calls with the same message template but different params are grouped together but pre-formatted templates are not.
As result the tool becames totally unusable: it displays tons of similar but unique messages.
Lib/asyncio/coroutines.py
Outdated
| return '<%s %s>' % (self.__class__.__name__, coro_repr) | ||
| coro_repr += f', created at {frame[0]}:{frame[1]}' | ||
|
|
||
| return '<{} {}>'.format(self.__class__.__name__, coro_repr) |
| logger.debug('%r communicate: feed stdin (%s bytes)', | ||
| self, len(input)) | ||
| logger.debug( | ||
| '%r communicate: feed stdin (%s bytes)', self, len(input)) |
There was a problem hiding this comment.
I think this can be made into f-string too?
| if family: | ||
| msg.append('family=%r' % family) | ||
| msg.append(f'family={family!r}' % family) |
There was a problem hiding this comment.
There's a remaining % family after the f-string
There was a problem hiding this comment.
Good catch, created a PR to fix this: #4787
Thanks!
https://bugs.python.org/issue32262