bpo-29463: Add docstring field to some AST nodes. #46

methane · 2017-02-12T09:16:56Z

ClassDef, ModuleDef, FunctionDef, and AsyncFunctionDef has docstring
field for now. It was first statement of there body.

vstinner · 2017-02-12T09:50:48Z

Doc/library/ast.rst

+
+   .. versionchanged:: 3.7
+      The docstring is exported from attribute of the node, instead of first
+      statement in it's body.


of its body

codecov · 2017-02-12T11:09:54Z

Codecov Report

Merging #46 into master will decrease coverage by -0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   82.37%   82.37%   -0.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350806     -142     
==========================================
- Hits       289089   288970     -119     
+ Misses      61859    61836      -23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2294f3a...e7ec3c1. Read the comment docs.

fixed

ClassDef, ModuleDef, FunctionDef, and AsyncFunctionDef has docstring field for now. It was first statement of there body.

vstinner

Just a minor nit, not a blocker one.

vstinner · 2017-02-22T11:03:14Z

Doc/library/ast.rst

+
+   .. versionchanged:: 3.7
+      The docstring is exported from attribute of the node, instead of first
+      statement of its body.


Sorry, the doc still sounds strange to me. I propose:

The docstring is now exported from the node docstring field, instead of the first body statement.

thanks. In above, I feel "AsyncFunctionDef is added" wrong too. How do you think?

Added :class:`AsyncFunctionDef` support

:class:`AsyncFunctionDef` is supported now

Ah, you're right:

:class:AsyncFunctionDef is now supported.

vstinner · 2017-02-22T15:32:19Z

Thanks for the last documentation fix ;-)

Nice enhancement, it should help to make AST code simpler!

Carreau · 2017-02-22T16:27:59Z

Thanks for this ! Improvement to the AST are welcome !

Would it have been possible to make the docstring optional ? (It's already breaking things, like IPython).

Should I comment on upstream bpo ?

methane · 2017-02-22T16:39:31Z

@Carreau Yes, please discuss on bpo. Merged pull request is not good place to discussion,
because it's too hard to search.

vstinner · 2017-02-22T16:50:00Z

Would it have been possible to make the docstring optional ? (It's already breaking things, like IPython).

I created http://bugs.python.org/issue29622

Carreau · 2017-02-22T16:55:46Z

Thanks @Haypo, responded and subscribed to both.

python/cpython#46 or bpo-29463 added docstring as a property to the module class that comes out of AST (so the free strings no longer appear an the first element in the parsed files).

python/cpython#46 / https://bugs.python.org/issue29463 move the module comment into the AST node and hence out of the tree which means the 2nd entry in the tree is now the import rather than the `__version__` string. Adds nightly on travis.

* FIX: install on python 3.7 python/cpython#46 / https://bugs.python.org/issue29463 move the module comment into the AST node and hence out of the tree which means the 2nd entry in the tree is now the import rather than the `__version__` string. Adds nightly on travis. * BLD: update python tags in setup.py * CI: switch to 3.7-dev * CI: allow failure on 3.7 dev

* Pin pytest to latest version 3.3.2 * Pin pytest-asyncio to latest version 0.8.0 * Pin pytest-aiohttp to latest version 0.3.0 * Update cherry_picker from 0.2.5 to 0.2.7 * Pin aiohttp to latest version 2.3.9 * Pin gidgethub to latest version 2.4.1 * Pin cachetools to latest version 2.0.1 * Pin requests to latest version 2.18.4 * Pin redis to latest version 2.10.6 * Pin celery to latest version 4.1.0 * Comment out python 3.7 from travis CI

Bump version number Closes python#46

Update pyproject.toml and setup.py Closes python#46 See merge request python-devs/importlib_resources!47

…sprint test: Fix fstring related tests in test_tokenize.py

Co-authored-by: Ken Jin <kenjin4096@gmail.com>

Email generators had been incorrectly flattening non-ASCII email addresses to RFC 2047 encoded-word format, leaving them undeliverable. (RFC 2047 prohibits use of encoded-word in an addr-spec.) This change raises a ValueError when attempting to flatten an EmailMessage with a non-ASCII addr-spec and a policy with utf8=False. (Exception: If the non-ASCII address originated from parsing a message, it will be flattened as originally parsed, without error.) Non-ASCII email addresses are supported when using a policy with utf8=True (such as email.policy.SMTPUTF8) under RFCs 6531 and 6532. Non-ASCII email address domains (but not localparts) can also be used with non-SMTPUTF8 policies by encoding the domain as an IDNA A-label. (The email package does not perform this encoding, because it cannot know whether the caller wants IDNA 2003, IDNA 2008, or some other variant such as UTS python#46.)

methane added the type-feature A feature request or enhancement label Feb 12, 2017

the-knights-who-say-ni added the CLA signed label Feb 12, 2017

vstinner previously requested changes Feb 12, 2017

View reviewed changes

methane force-pushed the ast-docstring branch from 16facf2 to e7ec3c1 Compare February 12, 2017 10:37

bpo-29463: Add docstring field to some AST nodes.

7666aaf

ClassDef, ModuleDef, FunctionDef, and AsyncFunctionDef has docstring field for now. It was first statement of there body.

methane force-pushed the ast-docstring branch from e7ec3c1 to 7666aaf Compare February 22, 2017 10:08

methane mentioned this pull request Feb 22, 2017

bpo-29598 Add couple of unit tests for pdb module #218

Closed

fix document. thanks travis!

68471d3

vstinner approved these changes Feb 22, 2017

View reviewed changes

doc fixes

56cc32e

vstinner merged commit cb41b27 into python:master Feb 22, 2017

methane deleted the ast-docstring branch February 22, 2017 16:31

myint mentioned this pull request May 14, 2017

Allow failure in "nightly" Python until we fix it PyCQA/pyflakes#90

Merged

myint mentioned this pull request May 28, 2017

Support Python 3.7 PyCQA/pyflakes#271

Closed

tacaswell mentioned this pull request Jul 9, 2017

Fix py37 changes sphinx-gallery/sphinx-gallery#265

Merged

tacaswell mentioned this pull request Oct 23, 2017

FIX: install on python 3.7 davidhalter/jedi#971

Merged

rogalski mentioned this pull request Nov 1, 2017

missing-docstring is emitted even with docstrings written. pylint-dev/pylint#1722

Closed

methane mentioned this pull request Feb 27, 2018

bpo-32911: Add new AST node for docstring #5927

Closed

iritkatriel referenced this pull request in iritkatriel/cpython Jul 22, 2021

add num_reps to test config (#46)

59618be

gvanrossum mentioned this pull request Apr 10, 2022

Test issue #47020

Closed

dkrystki mentioned this pull request May 3, 2022

Changes for 3.11 version break Reloadium (Hot reloader) functionality #92217

Closed

Alexamk mentioned this pull request Jun 2, 2022

Iterating over ChainMap.values() and ChainMap.items() updates underlying defaultdicts #93432

Closed

pjfarley3 mentioned this pull request Aug 7, 2022

os.remove() does not remove files in a sub-directory #95758

Closed

jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023

Update pyproject.toml and setup.py

496f4aa

Bump version number Closes python#46

jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023

Merge branch 'issue46' into 'master'

a4ad4ce

Update pyproject.toml and setup.py Closes python#46 See merge request python-devs/importlib_resources!47

isidentical referenced this pull request in isidentical/cpython Mar 25, 2023

Merge pull request #46 from mgmacias95/fstring-grammar-rebased-after-…

081f5a2

…sprint test: Fix fstring related tests in test_tokenize.py

oraluben pushed a commit to oraluben/cpython that referenced this pull request Jun 26, 2023

Fix: infer_BINARY_OP now supports smallint input (python#46)

46f6db4

Co-authored-by: Ken Jin <kenjin4096@gmail.com>

gvanrossum mentioned this pull request Aug 22, 2023

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

LinanV mentioned this pull request Oct 23, 2023

Objects/typeobject.c: No such file or directory. #111203

Closed

kcatss mentioned this pull request Feb 20, 2024

Use After Free at _heapreplace_max #115706

Closed

ngoldbaum mentioned this pull request Sep 23, 2024

Crash running PyO3 tests with --test-threads=1000 #124375

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-29463: Add docstring field to some AST nodes. #46

bpo-29463: Add docstring field to some AST nodes. #46

methane commented Feb 12, 2017

vstinner Feb 12, 2017

codecov bot commented Feb 12, 2017

vstinner left a comment

vstinner Feb 22, 2017

methane Feb 22, 2017

vstinner Feb 22, 2017

vstinner commented Feb 22, 2017

Carreau commented Feb 22, 2017 •

edited

Loading

methane commented Feb 22, 2017

vstinner commented Feb 22, 2017

Carreau commented Feb 22, 2017

bpo-29463: Add docstring field to some AST nodes. #46

bpo-29463: Add docstring field to some AST nodes. #46

Conversation

methane commented Feb 12, 2017

vstinner Feb 12, 2017

Choose a reason for hiding this comment

codecov bot commented Feb 12, 2017

Codecov Report

vstinner left a comment

Choose a reason for hiding this comment

vstinner Feb 22, 2017

Choose a reason for hiding this comment

methane Feb 22, 2017

Choose a reason for hiding this comment

vstinner Feb 22, 2017

Choose a reason for hiding this comment

vstinner commented Feb 22, 2017

Carreau commented Feb 22, 2017 • edited Loading

methane commented Feb 22, 2017

vstinner commented Feb 22, 2017

Carreau commented Feb 22, 2017

Carreau commented Feb 22, 2017 •

edited

Loading