bpo-32157: Remove explicit quotes around %r and {!r}. #4582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
changed the title
berkerpeksag
approved these changes
Nov 28, 2017
bitdancer
approved these changes
Nov 28, 2017
| @@ -1166,7 +1166,7 @@ def _match(self, cre, s): | |||
| self.mo = cre.match(s) | |||
| if __debug__: | |||
| if self.mo is not None and self.debug >= 5: | |||
| self._mesg("\tmatched r'%r' => %r" % (cre.pattern, self.mo.groups())) | |||
| self._mesg("\tmatched %r => %r" % (cre.pattern, self.mo.groups())) | |||
There was a problem hiding this comment.
I think what this actually wanted to be was r'%s' % cre.pattern.replace('\\\\', '\\'), but of course that doesn't work in all cases. It would be nice if we had a codec that produced raw string representation (it would have to fall back to repr for cases that can't be represented as raw strings).
There was a problem hiding this comment.
I will think about it.
rhettinger
approved these changes
Nov 28, 2017
|
Thank you all! Initially I was going to backport this change to 3.6 and 2.7, but now I am not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32157