-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip news] bpo-29879: Add versionadded where missing in typing.rst (and fix old Misc/NEWS) #4573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Travis failure looks like not my fault:
|
I'm going to try to close and re-open the PR in hopes that it will re-trigger travis build. 🍀 |
Looks good now :) Thanks! |
Mariatta
approved these changes
Nov 26, 2017
Great! :-) |
Thanks @ilevkivskyi for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
GH-4574 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 26, 2017
- Add "version added: 3.5.2" note where it was missing. - Remove the mention that Reversible is new in 3.5.2 (cherry picked from commit 0cd2e81)
Mariatta
pushed a commit
that referenced
this pull request
Nov 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #784
https://bugs.python.org/issue29879