Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip news] bpo-29879: Add versionadded where missing in typing.rst (and fix old Misc/NEWS) #4573

Merged
merged 1 commit into from
Nov 26, 2017

Conversation

ilevkivskyi
Copy link
Member

@ilevkivskyi ilevkivskyi commented Nov 26, 2017

@ilevkivskyi ilevkivskyi changed the title bpo-29879: Add versionadded where missing in typing.rst (and fix old Misc/NEWS) [skip news] bpo-29879: Add versionadded where missing in typing.rst (and fix old Misc/NEWS) Nov 26, 2017
@ilevkivskyi
Copy link
Member Author

The Travis failure looks like not my fault:

starting container process caused "could not create session key: disk quota exceeded"

@Mariatta Mariatta added needs backport to 3.6 skip news docs Documentation in the Doc dir labels Nov 26, 2017
@Mariatta
Copy link
Member

I'm going to try to close and re-open the PR in hopes that it will re-trigger travis build. 🍀

@Mariatta Mariatta closed this Nov 26, 2017
@Mariatta Mariatta reopened this Nov 26, 2017
@Mariatta
Copy link
Member

Looks good now :) Thanks!

@ilevkivskyi
Copy link
Member Author

Great! :-)

@Mariatta Mariatta merged commit 0cd2e81 into python:master Nov 26, 2017
@miss-islington
Copy link
Contributor

Thanks @ilevkivskyi for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-4574 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 26, 2017
- Add "version added: 3.5.2" note where it was missing.
- Remove the mention that Reversible is new in 3.5.2
(cherry picked from commit 0cd2e81)
Mariatta pushed a commit that referenced this pull request Nov 26, 2017
- Add "version added: 3.5.2" note where it was missing.
- Remove the mention that Reversible is new in 3.5.2
(cherry picked from commit 0cd2e81)
@ilevkivskyi ilevkivskyi deleted the typing-docs-versionadded branch November 26, 2017 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants