Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32030: Move PYTHONPATH to _PyMainInterpreterConfig #4511

Merged
merged 2 commits into from
Nov 23, 2017
Merged

bpo-32030: Move PYTHONPATH to _PyMainInterpreterConfig #4511

merged 2 commits into from
Nov 23, 2017

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 23, 2017

Move _PyCoreConfig.module_search_path_env to _PyMainInterpreterConfig
structure.

https://bugs.python.org/issue32030

Move _PyCoreConfig.module_search_path_env to _PyMainInterpreterConfig
structure.
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And this means at some point in the future we'll hopefully be able to replace the wchar_t * with a PyList * as PEP 432 describes :)

@vstinner vstinner requested a review from a team as a code owner November 23, 2017 00:21
@vstinner
Copy link
Member Author

Thanks! And this means at some point in the future we'll hopefully be able to replace the wchar_t * with a PyList * as PEP 432 describes :)

I'm not happy with the wchar_t* type neither, but please let me move step by step. Just the commit d434110 si already huge, whereas technically, it does almost nothing :-) While the PEP 432 is nice to read, it's not the case for the huge pile of legacy C code in CPython :-)

Moreover, I always fear the risk of regression, so I really prefer to make baby steps, and triple checks each commit, to make sure that we don't break anymore :-)

@ncoghlan
Copy link
Contributor

Aye, my comment was intended as praise for your strategy, not criticism. Consolidating the settings using their existing C level data types first, and only then looking at switching from C types to Python types makes a lot of sense :)

@vstinner vstinner merged commit e32e79f into python:master Nov 23, 2017
@vstinner vstinner deleted the move_pythonpath branch November 23, 2017 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants