bpo-32099: Add comment and improve variable name in roundrobin() recipe #4486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhettinger
added
needs backport to 3.6
skip news
docs
| try: | ||
| for next in nexts: | ||
| yield next() | ||
| except StopIteration: | ||
| pending -= 1 | ||
| nexts = cycle(islice(nexts, pending)) | ||
| # Remove the iterator we just exhausted from the cycle. |
There was a problem hiding this comment.
Large +1 for the comment!
serhiy-storchaka
approved these changes
Nov 21, 2017
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 21, 2017
(cherry picked from commit 337cbba)
|
GH-4487 is a backport of this pull request to the 3.6 branch. |
rhettinger
pushed a commit
that referenced
this pull request
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32099